From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44466: 27.1; quail input fails at read-only boundary Date: Sun, 08 Nov 2020 17:02:56 +0200 Message-ID: <83tutz6gdb.fsf@gnu.org> References: <878sbfvrs7.fsf@dick> <83eel56zze.fsf@gnu.org> <83wnyw5xx3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org To: Evgeny Zajcev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 08 16:04:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbmEj-0006wn-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Nov 2020 16:04:09 +0100 Original-Received: from localhost ([::1]:45910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbmEi-0002x6-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Nov 2020 10:04:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbmEc-0002wk-FV for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 10:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbmEc-0000vR-6h for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 10:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbmEc-0007pk-1a for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 10:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2020 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44466 X-GNU-PR-Package: emacs Original-Received: via spool by 44466-submit@debbugs.gnu.org id=B44466.160484778230038 (code B ref 44466); Sun, 08 Nov 2020 15:04:02 +0000 Original-Received: (at 44466) by debbugs.gnu.org; 8 Nov 2020 15:03:02 +0000 Original-Received: from localhost ([127.0.0.1]:32865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbmDd-0007oI-W6 for submit@debbugs.gnu.org; Sun, 08 Nov 2020 10:03:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbmDc-0007nu-1Z for 44466@debbugs.gnu.org; Sun, 08 Nov 2020 10:03:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50080) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbmDU-0000aq-MI; Sun, 08 Nov 2020 10:02:54 -0500 Original-Received: from [176.228.60.248] (port=3913 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbmDU-0003n2-5v; Sun, 08 Nov 2020 10:02:52 -0500 In-Reply-To: (message from Evgeny Zajcev on Sun, 8 Nov 2020 09:42:23 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192883 Archived-At: > From: Evgeny Zajcev > Date: Sun, 8 Nov 2020 09:42:23 +0300 > Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org > > > When an input method is used in a read-only buffer, Emacs barfs > > because it doesn't allow inserting text into such a buffer. It > > doesn't insert the untranslated character, as what your patch did. > > > >> Possible we need to check front-stickyness of the char at point along with 'read-only property: > >> > >> .. > >> (and (get-char-property (point) 'read-only) > >> (get-char-property (point) 'front-sticky))) > > > > Does this solve the problem in this case? > > Yes, because this mimics what is done in > verify_interval_modification() function from textprop.c. Any reason why pressing a key on a button should disregard the active input method? What if the button needs the user to type the character which the input method would produce? AFAIU, the patch we installed a year ago makes this impossible. > Possibly the best solution would be to make > verify_interval_modification() visible from elisp side and use it in > quail-input-method to check for writability at point. I think this would be overkill.