unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Evgeny Zajcev <lg.zevlg@gmail.com>
Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org
Subject: bug#44466: 27.1; quail input fails at read-only boundary
Date: Sun, 08 Nov 2020 17:02:56 +0200	[thread overview]
Message-ID: <83tutz6gdb.fsf@gnu.org> (raw)
In-Reply-To: <CAO=W_Zrb8QTAmD4eFh0fTu7J+n1CRY7uF+P_LqWgDjOesk9vMg@mail.gmail.com> (message from Evgeny Zajcev on Sun, 8 Nov 2020 09:42:23 +0300)

> From: Evgeny Zajcev <lg.zevlg@gmail.com>
> Date: Sun, 8 Nov 2020 09:42:23 +0300
> Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org
> 
> > When an input method is used in a read-only buffer, Emacs barfs
> > because it doesn't allow inserting text into such a buffer.  It
> > doesn't insert the untranslated character, as what your patch did.
> >
> >> Possible we need to check front-stickyness of the char at point along with 'read-only property:
> >>
> >> ..
> >>                   (and (get-char-property (point) 'read-only)
> >>                        (get-char-property (point) 'front-sticky)))
> >
> > Does this solve the problem in this case?
> 
> Yes, because this mimics what is done in
> verify_interval_modification() function from textprop.c.

Any reason why pressing a key on a button should disregard the active
input method?  What if the button needs the user to type the character
which the input method would produce?  AFAIU, the patch we installed a
year ago makes this impossible.

> Possibly the best solution would be to make
> verify_interval_modification() visible from elisp side and use it in
> quail-input-method to check for writability at point.

I think this would be overkill.





  reply	other threads:[~2020-11-08 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 13:48 bug#44466: 27.1; quail input fails at read-only boundary dick
2020-11-07 13:47 ` Eli Zaretskii
2020-11-07 22:24   ` Evgeny Zajcev
2020-11-08  3:29     ` Eli Zaretskii
2020-11-08  6:42       ` Evgeny Zajcev
2020-11-08 15:02         ` Eli Zaretskii [this message]
2020-11-08 16:07           ` lg.zevlg
2020-11-08 16:18             ` Eli Zaretskii
2020-11-08 19:50               ` lg.zevlg
2020-11-14 13:22                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tutz6gdb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44466@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=lg.zevlg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).