From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Sun, 07 Feb 2021 17:15:03 +0200 Message-ID: <83tuqnnc3s.fsf@gnu.org> References: <87czxc5cku.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1405"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46358@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 07 16:15:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8lmI-0000Dz-3r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 16:15:10 +0100 Original-Received: from localhost ([::1]:39396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8lmH-0003M3-6A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 10:15:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8lmA-0003Lr-Sx for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 10:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8lmA-0005XZ-LJ for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 10:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8lmA-0003IW-G1 for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 10:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2021 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161271090112655 (code B ref 46358); Sun, 07 Feb 2021 15:15:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 7 Feb 2021 15:15:01 +0000 Original-Received: from localhost ([127.0.0.1]:48470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8lm8-0003I3-F2 for submit@debbugs.gnu.org; Sun, 07 Feb 2021 10:15:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8lm7-0003Ho-4x for 46358@debbugs.gnu.org; Sun, 07 Feb 2021 10:14:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59571) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8lm1-0005Tt-5m; Sun, 07 Feb 2021 10:14:53 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3442 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l8lm0-0001rb-IS; Sun, 07 Feb 2021 10:14:52 -0500 In-Reply-To: <87czxc5cku.fsf@protesilaos.com> (message from Protesilaos Stavrou on Sun, 07 Feb 2021 13:42:09 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199500 Archived-At: > From: Protesilaos Stavrou > Date: Sun, 07 Feb 2021 13:42:09 +0200 > > In the attached patch, I do the following: > > 1. Define new faces. Each has semantic value in that it applies to > constructs implied by its name. Thanks. Would it be possible to use color names rather than #RRGGBB values? The latter makes it very hard to figure out the color that will be used by the face. > 4. Use new color combinations which conform with the WCAG AAA standard > for color contrast against pure white/black (this standard pertains > to legibility and is the highest of its kind). Not sure what that means in practical terms: most Emacs users I've watched working (myself included) use some background color other than pure black or white. Doesn't that change the contrast and the optimal colors? > With regard to point 2, I only use Git and thus cannot test the other > backends with the requisite degree of confidence. Do you think I should > try regardless? Or should we just support the Git backend and hope that > someone else will work on [some of] the other backends? If you can easily try other backends, it will be appreciated. But it is not mandatory, IMO. > On point 4, please consider this a proposal: it is a highly opinionated > change. If you feel we should in no way alienate existing users, I am > prepared to remove all colors and just :inherit from the faces that > applied before. Personally, I think inheriting from the existing faces will be less drastic, so it's probably better.