From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46827: Broken initial size of GTK3 frame Date: Tue, 02 Mar 2021 18:35:50 +0200 Message-ID: <83tupt5x95.fsf@gnu.org> References: <6caa020a-084c-e3f2-7a34-262f7127b21b@gmx.at> <87eegz41ui.fsf@gmail.com> <875z2b3srx.fsf@gmail.com> <87ft1fyo88.fsf@gmail.com> <8a346498-e7e3-ca92-e518-86f6fc2c37b7@gmx.at> <87y2f6spgm.fsf@gmail.com> <87v9aaslh9.fsf@gmx.net> <689ba08c-639f-af40-5c30-95dcceac552f@gmx.at> <359cec57-48d3-dc97-df0f-a778a0786001@gmx.at> <83zgzl63y0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46827@debbugs.gnu.org, rpluim@gmail.com, stephen.berman@gmx.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 17:36:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH80I-0005uF-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 17:36:10 +0100 Original-Received: from localhost ([::1]:54644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH80G-0001BS-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 11:36:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH80A-0001BH-Jo for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 11:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH80A-0002at-CS for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 11:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH80A-0005F1-AW for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 11:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46827 X-GNU-PR-Package: emacs Original-Received: via spool by 46827-submit@debbugs.gnu.org id=B46827.161470296120136 (code B ref 46827); Tue, 02 Mar 2021 16:36:02 +0000 Original-Received: (at 46827) by debbugs.gnu.org; 2 Mar 2021 16:36:01 +0000 Original-Received: from localhost ([127.0.0.1]:54081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH809-0005Ed-9D for submit@debbugs.gnu.org; Tue, 02 Mar 2021 11:36:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH806-0005EJ-JZ for 46827@debbugs.gnu.org; Tue, 02 Mar 2021 11:35:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43182) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH800-0002Yu-Nj; Tue, 02 Mar 2021 11:35:52 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1614 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lH800-000762-7a; Tue, 02 Mar 2021 11:35:52 -0500 In-Reply-To: (message from martin rudalics on Tue, 2 Mar 2021 17:07:16 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201226 Archived-At: > Cc: stephen.berman@gmx.net, rpluim@gmail.com, 46827@debbugs.gnu.org > From: martin rudalics > Date: Tue, 2 Mar 2021 17:07:16 +0100 > > > What's wrong with this place? > > Actually, it's not needed. I just have to call do_pending_window_change > _after_ updating the tool bar as in the attached patch. Thanks, but is there any reason to remove the call before updating the tool bar? You see, I believe one of the reasons for the need to clear_garbaged_frames is that call you suggest to remove. Why not leave it there, and _add_ one more call after prepare_menu_bars (and perhaps condition it on the same condition as prepare_menu_bars)? > > But please note that after calling > > do_pending_window_change you need to perform the "maybe the selected > > window changed" dance we do after other similar calls. > > I suppose the > > do_pending_window_change could change the selected_window due to > frame resizing which makes the selected window too small. > > is some sort of cargo cult now. While frame resizing can make the > selected window small, it will neither remove nor change it. Never-ever? > > Otherwise, I'm okay with this change, but only on master. Emacs 27.2 > > will have to make do with what we have now. > > Don't worry. Even on master we could condition it on GTK3. I'd just > want to find out why it works around the problem in the first place. I suspect that the code which calculates the dimensions of the tool bar causes this. > And I have a second, similar GTK3-only frame resizing problem with a > similar effect that, however, becomes virulent only after resizing a > frame manually with the mouse. Fun.