From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Mon, 03 May 2021 21:33:29 +0300 Message-ID: <83tunj651i.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32878"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 20:34:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lddOU-0008RB-LM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 20:34:10 +0200 Original-Received: from localhost ([::1]:47252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lddOT-0004nH-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 14:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lddOM-0004lW-FZ for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lddOM-00077c-7N for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lddOM-0003qY-4G for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 14:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162006683714780 (code B ref 48137); Mon, 03 May 2021 18:34:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 3 May 2021 18:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:48041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lddOH-0003qK-CJ for submit@debbugs.gnu.org; Mon, 03 May 2021 14:33:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lddOF-0003qB-QW for 48137@debbugs.gnu.org; Mon, 03 May 2021 14:33:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59914) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lddOA-000704-Je; Mon, 03 May 2021 14:33:50 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lddO6-0006uZ-LB; Mon, 03 May 2021 14:33:47 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 03 May 2021 14:23:53 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205554 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 48137@debbugs.gnu.org > Date: Mon, 03 May 2021 14:23:53 -0400 > > > Thanks Stefan. Does this also apply to the only other use of > > `insert-file-contents-literally' in 'package,? > > I don't think so, no. > > > In particular `package--with-response-buffer-1' is referenced by > > `package-check-signature' > > This definitely needs to deal with bytes only, we don't want any > encoding/decoding to risk changing the byte contents. > > > and `package--download-one-archive'. > > I think the same is true here. > > > (I am personally more in favor of supporting DOS files, because it > > makes the caller's life easier on MS-Windows and brings them on par > > with Unix, though Eli's concern has to be addressed first) > > My own opinion is that .el files are files that belong to Emacs and they > should use Emacs's "native" file format, whatever that is. I think the > "most native" would be `utf-8-emacs-unix` so I'd be OK with deprecating > all other encodings, but I don't think that's going to happen ;-) I think it's wrong for package.el to try to decode these files. It should deliver the files to the disk exactly as they are received through the wire. And the only safe way of doing that is to treat these files as raw bytes. Where we must interpret some parts of the files, we should take precautions to handle the complications related to the encoding, but we should not try to decode anything.