From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time Date: Thu, 27 May 2021 16:45:20 +0300 Message-ID: <83tumo8f4f.fsf@gnu.org> References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48578@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 27 16:01:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmGZc-0001TX-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 16:01:20 +0200 Original-Received: from localhost ([::1]:37038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGZb-00075Q-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 10:01:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGKo-0001UB-Ut for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 09:46:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39365) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmGKo-0006wk-HQ for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmGKo-0003pI-E1 for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 May 2021 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48578 X-GNU-PR-Package: emacs Original-Received: via spool by 48578-submit@debbugs.gnu.org id=B48578.162212312614659 (code B ref 48578); Thu, 27 May 2021 13:46:02 +0000 Original-Received: (at 48578) by debbugs.gnu.org; 27 May 2021 13:45:26 +0000 Original-Received: from localhost ([127.0.0.1]:50911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmGKE-0003oM-Kh for submit@debbugs.gnu.org; Thu, 27 May 2021 09:45:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmGKC-0003o9-UG for 48578@debbugs.gnu.org; Thu, 27 May 2021 09:45:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44356) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGK3-0006Xf-IK; Thu, 27 May 2021 09:45:19 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGK2-0003Tg-U7; Thu, 27 May 2021 09:45:15 -0400 In-Reply-To: (message from Andrea Corallo on Thu, 27 May 2021 11:57:22 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207376 Archived-At: > From: Andrea Corallo > Cc: 48578@debbugs.gnu.org > Date: Thu, 27 May 2021 11:57:22 +0000 > > > . why do you use Fexpand_file_name _after_ realpath? shouldn't we > > call it before realpath instead? > > Right that's correct. > > > . we need to encode the file name before passing it to realpath, and > > decode the result, right? > > Correct > > > . realpath could potentially return NULL, and we should check for > > that, and return the result of Fexpand_file_name if it does > > Of course > > > . we don't need to support remote files here via file-handlers, > > right? > > Correct, so far we do not support it. > > > If you agree with the above, I will prepare a proper patch and install > > it, including the necessary changes for WINDOWSNT. > > Agreed, thanks. Thanks, I installed a fix along these lines, please review and comment.