From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment Date: Fri, 28 May 2021 17:16:53 +0300 Message-ID: <83tumn6izu.fsf@gnu.org> References: <871r9t6pgd.fsf@gnus.org> <838s40acf9.fsf@gnu.org> <87sg273fqo.fsf@gnus.org> <83fsy78l2p.fsf@gnu.org> <49c82e08-f15e-e564-1740-86271fc94f3b@yandex.ru> <8335u780u6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: robin.neatherway@gmail.com, larsi@gnus.org, dgutov@yandex.ru, 20846@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 28 16:17:56 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmdJE-0009tM-DL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 May 2021 16:17:56 +0200 Original-Received: from localhost ([::1]:55040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmdJD-0006Q9-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 May 2021 10:17:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmdIM-0005UH-77 for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 10:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmdIL-0006fT-Rr for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 10:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmdIL-0003kC-JT for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 10:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 May 2021 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20846 X-GNU-PR-Package: emacs Original-Received: via spool by 20846-submit@debbugs.gnu.org id=B20846.162221142014382 (code B ref 20846); Fri, 28 May 2021 14:17:01 +0000 Original-Received: (at 20846) by debbugs.gnu.org; 28 May 2021 14:17:00 +0000 Original-Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmdIK-0003ju-E0 for submit@debbugs.gnu.org; Fri, 28 May 2021 10:17:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmdIG-0003jf-BX for 20846@debbugs.gnu.org; Fri, 28 May 2021 10:16:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55782) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmdIA-0006Yq-7F; Fri, 28 May 2021 10:16:50 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4908 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmdI9-0005q1-AT; Fri, 28 May 2021 10:16:50 -0400 In-Reply-To: (message from Stefan Monnier on Fri, 28 May 2021 10:09:41 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207463 Archived-At: > From: Stefan Monnier > Cc: Dmitry Gutov , larsi@gnus.org, > robin.neatherway@gmail.com, 20846@debbugs.gnu.org > Date: Fri, 28 May 2021 10:09:41 -0400 > > > Then that sentence is misleading and should be rephrased, because my > > reading of it is that it clearly states that auto-indentation inside > > strings is generally impossible, and expects the implementations to > > behave like that. > > [ It does not say intend to that. It says to return `noindent` when > indentation is impossible and gives "inside a string" as an example of > a reason why indentation might not be possible. ] Then how about saying the below instead? If it is called somewhere where it cannot auto-indent, the function should return `noindent' to signal that it didn't. (I intentionally removed the example because I think it isn't really needed, and is actually harmful in this case.)