From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50599: [PATCH] Don't recommend against "\[...]" substitutions for performance Date: Wed, 15 Sep 2021 11:24:14 +0300 Message-ID: <83tuimb61d.fsf@gnu.org> References: <83v932bawy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19501"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50599@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 15 10:25:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQQEJ-0004s4-QD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 10:25:19 +0200 Original-Received: from localhost ([::1]:33338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQEI-0007kZ-O8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 04:25:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQE2-0007eF-SR for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 04:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQQE2-0004xJ-LK for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQQE2-0000Np-HU for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 04:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Sep 2021 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50599-submit@debbugs.gnu.org id=B50599.16316942661428 (code B ref 50599); Wed, 15 Sep 2021 08:25:02 +0000 Original-Received: (at 50599) by debbugs.gnu.org; 15 Sep 2021 08:24:26 +0000 Original-Received: from localhost ([127.0.0.1]:50806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQQDS-0000Mx-1j for submit@debbugs.gnu.org; Wed, 15 Sep 2021 04:24:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQQDQ-0000Mk-Ks for 50599@debbugs.gnu.org; Wed, 15 Sep 2021 04:24:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56632) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQDL-0004Mz-B9; Wed, 15 Sep 2021 04:24:19 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQDK-0005xX-Uk; Wed, 15 Sep 2021 04:24:19 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 15 Sep 2021 09:11:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214368 Archived-At: > From: Stefan Kangas > Date: Wed, 15 Sep 2021 09:11:02 +0200 > Cc: 50599@debbugs.gnu.org > > According to /proc/cpuinfo, machine has a Intel(R) Core(TM) i7-3770 > CPU @ 3.40GHz. I believe this CPU was first released in 2013, and if > I'm not mistaken was not on the high-end even then. Your machine is quite fast, even though it's 8 years old. (Mine is 9 years old, and is faster.) There are many machines in use out there that are much, much slower. > > So I'm okay with somehow modifying the text to provide a better idea > > of what "very many" means nowadays, but I think the advice is still > > valid and shouldn't be removed. We cannot guarantee that arbitrarily > > large number of such references will not slow down help display. > > Formally, it is correct that if you throw very large inputs at > `substitute-command-keys', you will start to notice performance > issues. But when evaluating performance considerations we must also > consider what inputs we will realistically expect to see. We have no idea what could Lisp programmers out there want to do with this. For example, I could envision some programmatically generated help text with many such references. Where there are limitations due to the implementation, we should strive to let people know about them. > But this advice is completely irrelevant for everyone else, and only > wastes valuable space in the reference manual. I disagree with the "completely irrelevant" part, the general advice to keep the use of \\[..] to the minimum is still valid, so deleting that text entirely throws away the baby together with the bathwater. We should adapt the text to modern CPUs without losing the basic idea.