From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Thu, 16 Sep 2021 22:07:56 +0300 Message-ID: <83tuik8hkj.fsf@gnu.org> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <87tuikl79i.fsf@gmx.de> <83v9308jb9.fsf@gnu.org> <87pmt8l5rj.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, 49723@debbugs.gnu.org, federicotedin@gmail.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 21:09:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQwku-0006HX-N0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 21:09:08 +0200 Original-Received: from localhost ([::1]:38560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQwkt-0003Nu-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 15:09:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQwko-0003Nj-8B for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 15:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQwko-0002Ho-0B for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 15:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQwkn-0003qe-Rt for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 15:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.163181929514719 (code B ref 49723); Thu, 16 Sep 2021 19:09:01 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 16 Sep 2021 19:08:15 +0000 Original-Received: from localhost ([127.0.0.1]:56583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwk2-0003pJ-Vs for submit@debbugs.gnu.org; Thu, 16 Sep 2021 15:08:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwk1-0003p5-D1 for 49723@debbugs.gnu.org; Thu, 16 Sep 2021 15:08:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32848) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQwjw-0001ZS-6u; Thu, 16 Sep 2021 15:08:08 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3139 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQwjv-0008CD-H6; Thu, 16 Sep 2021 15:08:08 -0400 In-Reply-To: <87pmt8l5rj.fsf@gmx.de> (message from Michael Albinus on Thu, 16 Sep 2021 20:44:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214503 Archived-At: > From: Michael Albinus > Cc: federicotedin@gmail.com, phst@google.com, 49723@debbugs.gnu.org > Date: Thu, 16 Sep 2021 20:44:32 +0200 > > >> Should this be implemented also in remote file names? > > > > Are we sure remote file names cannot include null bytes? > > Likely not. I have added "foo\0bar" as file name in tramp-test.el, and > then I get > > --8<---------------cut here---------------start------------->8--- > Test tramp-test41-special-characters condition: > (ert-test-failed > ((should > (file-exists-p file1)) > :form > (file-exists-p "/mock:gandalf:/tmp/tramp-testkLeKOx/foo\0bar") > :value nil)) > FAILED 1/1 tramp-test41-special-characters (0.484141 sec) > > --8<---------------cut here---------------end--------------->8--- > > Well, perhaps Tramp can be improved to handle null bytes on (remote) > shell level, but do we need this? I'm not sure.