From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Mon, 17 Jan 2022 20:51:07 +0200 Message-ID: <83tue2urfo.fsf@gnu.org> References: <87czn1gfb1.fsf@web.de> <838rx9zs9r.fsf@gnu.org> <87h7bxg2d8.fsf@web.de> <835ysdzq4s.fsf@gnu.org> <87czmlg1rz.fsf@web.de> <227d35a5bc25a5f57453@heytings.org> <87zgppekxe.fsf@web.de> <227d35a5bcdae0a85f4d@heytings.org> <87v90dekii.fsf@web.de> <227d35a5bc14f7b3c75c@heytings.org> <87r1b1ejif.fsf@web.de> <227d35a5bc16d5c159ac@heytings.org> <87fsrg8ep4.fsf@web.de> <87bl22n7ut.fsf@web.de> <877dcqn5kx.fsf@web.de> <86h7bur9yi.fsf@mail.linkov.net> <864k68ujbx.fsf@mail.linkov.net> <861r1aoi9i.fsf@mail.linkov.net> <867daz1jo1.fsf@mail.linkov.net> <83mtjuwm8c.fsf@gnu.org> <86a6fuxkz1.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14899"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, gregory@heytings.org, 51883@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 17 19:53:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9X8P-0003gG-Mq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jan 2022 19:53:41 +0100 Original-Received: from localhost ([::1]:51726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9X8O-0007E4-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jan 2022 13:53:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X6o-00072D-RU for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9X6o-0006XB-GI for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9X6o-0004mh-G8 for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jan 2022 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.164244549718336 (code B ref 51883); Mon, 17 Jan 2022 18:52:02 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 17 Jan 2022 18:51:37 +0000 Original-Received: from localhost ([127.0.0.1]:47976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9X6P-0004lf-D9 for submit@debbugs.gnu.org; Mon, 17 Jan 2022 13:51:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9X6O-0004lS-5k for 51883@debbugs.gnu.org; Mon, 17 Jan 2022 13:51:36 -0500 Original-Received: from [2001:470:142:3::e] (port=46046 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X67-0006JJ-KH; Mon, 17 Jan 2022 13:51:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2dR03C8sqwtjPzBi68YJri4d8OoALgWqfvZ/zTVq4ng=; b=CGSMGPRSA+7O huA2wN6Nj9LDszW+WD6hVDO0Z0qDRvJsTDAp7c9DKU/n2lZmV+vMDkjXv2vEpQegtSCknvjREnp61 dg82wutVrPd1F4GnwVk/K9B9NuAnUsPO+oF0psYaENYfkBMilQ65LPY8SmgDiUyqVAJ+/mMlhAj3v /3vbNBnqQNX32S+GLL0nO8DIcpcvTtlvmVFMxQDWExN9/Q/Ut+spRMBZP/aiHxsIKiFtBDstc37WR BJObvh9NovB2hErvllMT1rU6t4DaGZrMP9cjvnEXriL+2GsIowTE3/0KAoCb8CYyPe3hTfAttQYw9 bzURTpXhZtwwC0yiIn6K/g==; Original-Received: from [87.69.77.57] (port=4891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X64-0000Hb-Gh; Mon, 17 Jan 2022 13:51:17 -0500 In-Reply-To: <86a6fuxkz1.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 17 Jan 2022 20:41:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224474 Archived-At: > From: Juri Linkov > Cc: michael_heerdegen@web.de, gregory@heytings.org, 51883@debbugs.gnu.org > Date: Mon, 17 Jan 2022 20:41:26 +0200 > > >> > I tried to use this, but undelete-frame-mode in the File menu > >> > makes no sense: when you mistakenly deleted a frame, you want > >> > to undelete it immediately, so you open the File menu, and > >> > see the message "No way, you can't undelete the deleted frame, > >> > because you were careless and not enabled a special mode". > >> > > >> > So the most useful case for this feature is to get the > >> > accidentally deleted frame back, and it fails to do this. > >> > > >> > Instead, it allows undeleting 16 frames in a special mode. > >> > Is there really a human that can delete 16 frames, and then > >> > remember what was on the 16th frame back? > >> > > >> > Rereading this thread indicates that the only concern about > >> > enabling this by default was the memory footprint for remembering > >> > 16 frames. OTOH, this feature is really useful for remembering > >> > 1 frame. So this is what should be enabled by default: > >> > >> It seems this is the right thing to do, so now pushed to master. > > > > I'm sorry, you cannot do that. We discussed this at some length and > > reached certain conclusions. Then you come and in effect say those > > considerations and discussions make no sense, and you know better? > > Let's please respect our discussions and decisions more than that. > > And if you want others to respect your opinions, please respect > > theirs, even if you disagree. The feature as installed allows you to > > customize it to have that mode turned on by default, so you could > > easily fix your problem by doing that. > > > > Specifically to your main argument: it is no different from deleting a > > file: unless the user took steps to configure the system to allow > > undeleting deleted files, deleted files are lost forever. Moreover, > > in the case of an Emacs frame, nothing of terrible importance is > > actually lost: the buffers displayed in that frame are still there, > > and restoring the deleted frame by hand shouldn't take more than a few > > moments. > > > > So I reverted this changeset. Please in the future don't make such > > changes unilaterally. > > This is not true. This is not a unilateral change. I posted a patch, > then waited for comments 3 days, and when no one commented this means > that everyone agreed that it's a more reasonable change, then pushed to > master. I guess 3 days is not enough, especially in this time of year. My rule of thumb is to wait at least a week, possibly two. But in any case, the amount of time you waited is not the main issue here. The main issue is that we decided to implement this the way we did, and you were even part of that discussion. It makes no sense to undo all that because you suddenly don't like the results.