From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 06 Jul 2022 05:29:08 +0300 Message-ID: <83tu7v6kjv.fsf@gnu.org> References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: terra@diku.dk, 56407@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 04:30:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8uo2-0003De-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 04:30:23 +0200 Original-Received: from localhost ([::1]:42764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8uo1-0002UB-KB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 22:30:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8unj-0002Sa-5b for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 22:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8uni-0001zz-RQ for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 22:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8uni-0002FJ-KG for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 22:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.16570745728574 (code B ref 56407); Wed, 06 Jul 2022 02:30:02 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 02:29:32 +0000 Original-Received: from localhost ([127.0.0.1]:51973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8unE-0002ED-6c for submit@debbugs.gnu.org; Tue, 05 Jul 2022 22:29:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8unA-0002Dz-65 for 56407@debbugs.gnu.org; Tue, 05 Jul 2022 22:29:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8un2-0001ud-SR; Tue, 05 Jul 2022 22:29:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=aEZfX5/oyZzOK7CBXoRxv7Yvn287D6iYCfQju1OfqoM=; b=VfM4Ug2gnV+vDGVmt1fl ARLTr3v5Uwf/EcFghia6m4PveNapGlUL2gSoK3D4LIJapUJh08dxhprH9Txaqv/je1PM3E44dWF3I SVdUFjSA2M9FYdAO+dtyKGrtcSvq9xKSw7HeoQEW4D/bvNuZySVsdH/VZKdiC3cDHx3i3XyDlcB5n 7afFJrn9O4TPCjHqqSL43wuo4lw9Ms6w2pjM0qyTzmIbq0wOgySgzoNq079DUhPku2001RJHZXYze HXleFRUIr07EzV0DROGorVWUMMy6Mxx4vzPhLewaDoTsi3cUHe45PRVTkWdiCicz6Fh5AtdOpHaeB r/9/C/qczm0mnw==; Original-Received: from [87.69.77.57] (port=3022 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8umx-00015k-Da; Tue, 05 Jul 2022 22:29:17 -0400 In-Reply-To: <87tu7vpc8y.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Tue, 05 Jul 2022 20:53:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236193 Archived-At: > From: João Távora > Cc: 56407@debbugs.gnu.org, terra@diku.dk > Date: Tue, 05 Jul 2022 20:53:33 +0100 > > Eli Zaretskii writes: > > >> I confirmed this with a stack trace requested from the user and came up > >> with this workaround in the user's config: > >> > >> (add-to-list 'desktop-minor-mode-handlers > >> '(eglot--managed-mode . ignore)) > >> > >> This works, but we should come up with something better. > > > > But why is the above not good enough? You could also use > > desktop-minor-mode-table, which is a defcustom. > > At first I thought it was a customization variable and that would make > it user-specific overwritable etc. But I see now that evidently it is > not. According to the docstring of d-m-m-handlers, eglot.el could just > just contain the above invocation, indeed. > > But that has the downside that eglot.el must require "desktop.el" which > IMO opinion too strongly couples the two packages. I see no reason to require: you just add a value to the list, that's all. > I think I like Lars's solution best. I don't: it makes the information spread out and harder to find.