From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Tue, 02 Aug 2022 22:18:24 +0300 Message-ID: <83tu6u5u9r.fsf@gnu.org> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14533"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56896@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 02 21:21:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIxST-0003cI-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 21:21:37 +0200 Original-Received: from localhost ([::1]:48434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIxSS-0007m0-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 15:21:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxPz-0004zR-0t for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:19:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIxPy-0003e7-IH for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIxPy-0007S4-AK for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165946792128614 (code B ref 56896); Tue, 02 Aug 2022 19:19:02 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 19:18:41 +0000 Original-Received: from localhost ([127.0.0.1]:45104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxPc-0007RR-S0 for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:18:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxPY-0007RC-W4 for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 15:18:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxPT-0003bV-PD; Tue, 02 Aug 2022 15:18:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JutRUlDKdZfwedFeqBXF2fRN1cMwCEa6nMAOjs3wrOU=; b=PpQlt3FIrDQV KOHsj+HelkUPQe9dNA3sT5ETZz4kCASeh8ydQsbo8MfxdWfRTZVqR1gBCBWGyG8lGkDneogDReNzf BWiOC/n9FoAdylPQm5yO8yq+x+bHNxPLWtsZk4dBmw+PfTcxK8ZPnv+gF3RA0CRHpwaf2tshby/Da RYGm75QQE5NJKxnNE5T/OxIgpXDh+tk/wgW64nCkj9hL4O8E0MEWN+IBYlL2uEDmhE6izqfRZmz+W Y4iy77id31eWTGUFBYMTqdvWeLDaYt4xPPzjzrGzaZyPmb0o2vA4pxoNDjOBo6v5wMu/UCp7ltnYt bIc+uKPkkJ0gmcm4Xh0x0A==; Original-Received: from [87.69.77.57] (port=2097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxPT-0008Mf-90; Tue, 02 Aug 2022 15:18:31 -0400 In-Reply-To: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> (message from Jim Porter on Tue, 2 Aug 2022 12:13:44 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238579 Archived-At: > From: Jim Porter > Date: Tue, 2 Aug 2022 12:13:44 -0700 > > Currently, the bookmark fringe icon is a circle. However, Emacs already > uses a circle to represent breakpoints (as do a lot of other IDEs). > These are usually a different color, but I think it would be nice if the > bookmark fringe icon were a different shape too. This would help > colorblind users, since (depending on their Emacs theme and what kind of > colorblindness they have), it might be hard to distinguish the bookmark > icon from the breakpoint icon. > > It would help make the purpose of the indicator more obvious to users > who don't directly use bookmarks. Some packages (including the built-in > org-capture package) set bookmarks automatically, and a user might not > realize that the dot indicates a bookmark, as opposed to some other thing. > > Attached are some screenshots showing before/after, plus a patch for > this. I converted the string definition of the bitmap to a vector of > (binary) numbers, since then a reader can see the shape of the icon if > they look carefully. Why not make the icon customizable, and offer several possible bitmaps to chose from? Hardcoding a single icon will always annoy someone. Thanks.