From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 19:47:33 +0300 Message-ID: <83tu6ltlcq.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23082"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57079@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 18:48:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLSP7-0005nT-V0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 18:48:30 +0200 Original-Received: from localhost ([::1]:35308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLSP6-0004Rl-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 12:48:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLSOh-0004NB-8s for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:48:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLSOf-0007N3-Pu for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLSOf-000243-L1 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.16600636707851 (code B ref 57079); Tue, 09 Aug 2022 16:48:01 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 16:47:50 +0000 Original-Received: from localhost ([127.0.0.1]:44644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLSOT-00022X-Vj for submit@debbugs.gnu.org; Tue, 09 Aug 2022 12:47:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLSOS-00021o-B3 for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 12:47:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLSON-0007M0-32; Tue, 09 Aug 2022 12:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6aJd25w3vq0hoarY6hczHUTEscKpuKuhMSs8VfqOBw0=; b=cwyp+OM4IIje VQZDz01MjTytEJwwV1oBE6yNsYcpS/YQr/FbLStn8yM7JBQkU3/HiYlyLQ+YIBOZQYTD20VlZjCpj EvuQocyW0mheRuUUyGrQQBN1h+r0bNsPNs0fe+uR5gJMyQOgdGPkmnzHjOZ+V1foHEN1dUA4/M+3z 9T1e+ATVTRNOzAQAPJTikLGE3B86CxvjjseknBxMI8crUa3qAQ9ugQ5v0/PBvgak2z986eWNp63wt g1AMYuC8FjrSqTSv1KDQioGgpLt+xWW7/E4sPvNG/YbE83WmnwtXgutaBbb3havuRcvnf3lGLz/OY 23f86EQbc5KAeR2Xgv3LPw==; Original-Received: from [87.69.77.57] (port=2173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLSOM-0002rM-EA; Tue, 09 Aug 2022 12:47:42 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 9 Aug 2022 09:11:07 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239169 Archived-At: > From: Stefan Kangas > Date: Tue, 9 Aug 2022 09:11:07 -0700 > > Severity: minor > > `seq-uniq' is not very performant compared to `-uniq' (from dash.el) and > even slower compared to the recently removed `gnus-delete-duplicates': > > (benchmark-run 10000 (seq-uniq '(a c b c c a d))) > => (0.355001481 1 0.2518970439999748) > > (benchmark-run 10000 (-uniq '(a c b c c a d))) > => (0.006599549 0 0.0) > > (benchmark-run 10000 (gnus-delete-duplicates '(a c b c c a d))) > => (0.0034537929999999997 0 0.0) > > Could we improve the performance of `seq-uniq' for lists? What's wrong with using delete-dups for your cases above?