From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Thu, 13 Oct 2022 13:34:25 +0300 Message-ID: <83tu489fm6.fsf@gnu.org> References: <875yhzmz25.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> <87wn98nlhq.fsf@gnus.org> <87lepo9c1e.fsf@posteo.net> <87r0zfkxzx.fsf@gnus.org> <87pmeyg24x.fsf@posteo.net> <87edvef8nc.fsf@gnus.org> <871qre2l63.fsf@posteo.net> <875ygqf7pc.fsf@gnus.org> <87r0ze15rt.fsf@posteo.net> <871qref5mq.fsf@gnus.org> <875ygohztx.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 57639@debbugs.gnu.org, info@protesilaos.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 12:36:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivZj-0008rF-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 12:36:28 +0200 Original-Received: from localhost ([::1]:35044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oivZh-0002Mj-JF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 06:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivYN-0002LV-Eu for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oivYM-0008NW-Fo for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oivYM-0006Ka-Ai for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166565726824290 (code B ref 57639); Thu, 13 Oct 2022 10:35:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 13 Oct 2022 10:34:28 +0000 Original-Received: from localhost ([127.0.0.1]:59690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivXo-0006Ji-2W for submit@debbugs.gnu.org; Thu, 13 Oct 2022 06:34:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivXl-0006JQ-Tx for 57639@debbugs.gnu.org; Thu, 13 Oct 2022 06:34:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivXg-0008EV-MH; Thu, 13 Oct 2022 06:34:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PGqkkAftZcehbGHxszVknjdkxpAoR8Fcl66faz+WSfs=; b=OA1x9/FD3Ox8 rHhZfBy06AzoCXukx38u43APDyhedmMv++F/EnSrt2fu4plCMsGqawDyMTiai1gcuFdwJf9as2JVL dT5JWE/bAWWWAFozB58vRC7oO+QfHEWSHG4+V0qJ52z8I6dovLWwPoS8OeRzaWFHEYZAsdnI7NNRz 4w5LIg5wr57blb19+O+Wk8k7pOrsoLR31dFCU266OAOWwk94NOHjH984NfF7fFY0FqR1awOT32PHY 3viVlcXrHxF+aZeo8pElCTY2pNsdB1tfDv/aZvHQDK21W0kIfggiMvrEfRM9pdPh3NdAg66xjEbRY riyI/Ts+rIDnECHJCLNijw==; Original-Received: from [87.69.77.57] (port=3139 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivXW-0005rX-R4; Thu, 13 Oct 2022 06:34:19 -0400 In-Reply-To: <875ygohztx.fsf@posteo.net> (message from Philip Kaludercic on Thu, 13 Oct 2022 08:50:34 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245289 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos > Stavrou > Date: Thu, 13 Oct 2022 08:50:34 +0000 > > Lars Ingebrigtsen writes: > > > Philip Kaludercic writes: > > > >> Great, can you point me to the places I would have to make changes for > >> this to work: > >> > >> add a function to loaddefs-gen that only fetched those for the > >> Emacs build (it'd almost be trivial -- we just bind > >> lisp-mode-autoload-regexp to ";;;###theme-autoload" and then > >> point the scraping function at etc/themes). > > > > I think you'd basically put something like the following into > > `loaddefs-generate--emacs-batch' -- > > > > (let ((lisp-mode-autoload-regexp > > "^;;;###\\(\\(noexist\\)-\\)?\\(theme-autoload\\)")) > > (loaddefs-generate > > (expand-file-name "../etc/themes/" lisp-directory) > > (expand-file-name "theme-loaddefs.el" lisp-directory))) > > > > Then you have to teach `loaddefs-generate--make-autoload' to generate > > the correct forms as a result of the `deftheme' -- which should be some > > `put's. > > OK, it looks like this worked. Just to recap, these are the proposed > changes: What, if anything, does this mean for themes that aren't bundled with Emacs? Also, this needs a NEWS entry. Thanks.