unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: thievol@posteo.net, larsi@gnus.org, 58446@debbugs.gnu.org,
	monnier@iro.umontreal.ca
Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer
Date: Fri, 14 Oct 2022 22:14:06 +0300	[thread overview]
Message-ID: <83tu466ww1.fsf@gnu.org> (raw)
In-Reply-To: <87sfjqxm6k.fsf@gmx.de> (message from Michael Albinus on Fri, 14 Oct 2022 21:03:15 +0200)

> Cc: Thierry Volpiatto <thievol@posteo.net>, Lars Ingebrigtsen <larsi@gnus.org>,
>  58446@debbugs.gnu.org
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Fri, 14 Oct 2022 21:03:15 +0200
> 
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> Hi Stefan,
> 
> >>> - The name `file-attribute-file-number` doesn't sound right
> >>>   because it doesn't return a number.
> >> The name is a reminiscence of the existing variable buffer-file-number,
> >> which serves exactly the same purpose.
> >
> > One error doesn't justify another.
> > Maybe a better name would be "file identifier"?
> 
> True, but I'd let decide the maintainers.

It would be better, yes.  I already changed "device number" to eithe
just "device" or "device identifier", in the documentation you touched
today, since talking about "device number" when it can be a cons of 2
numbers doesn't sound like a good idea.





  reply	other threads:[~2022-10-14 19:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 18:11 bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Thierry Volpiatto
2022-10-12 11:13 ` Lars Ingebrigtsen
2022-10-12 14:57   ` Michael Albinus
2022-10-13  6:31     ` Lars Ingebrigtsen
2022-10-13  7:09       ` Eli Zaretskii
2022-10-13 19:16         ` Michael Albinus
2022-10-14 17:04     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 17:28       ` Michael Albinus
2022-10-14 18:34         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 19:03           ` Michael Albinus
2022-10-14 19:14             ` Eli Zaretskii [this message]
2022-10-14 19:33               ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tu466ww1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58446@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=michael.albinus@gmx.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).