From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Date: Tue, 15 Nov 2022 14:34:21 +0200 Message-ID: <83tu30iegi.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59266@debbugs.gnu.org To: Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 13:40:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouvEs-000792-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 13:40:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouv9d-0000f1-PV; Tue, 15 Nov 2022 07:35:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouv9a-0000aH-ID for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 07:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouv9a-0000GP-9f for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 07:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouv9Z-0000zf-QT for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 07:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 12:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59266-submit@debbugs.gnu.org id=B59266.16685156573763 (code B ref 59266); Tue, 15 Nov 2022 12:35:01 +0000 Original-Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 12:34:17 +0000 Original-Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouv8r-0000yd-A9 for submit@debbugs.gnu.org; Tue, 15 Nov 2022 07:34:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouv8p-0000yP-5f for 59266@debbugs.gnu.org; Tue, 15 Nov 2022 07:34:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouv8j-0000Aa-2r; Tue, 15 Nov 2022 07:34:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ugOFawg209DdC89EZ/wrUU0jgLwdU80Qct5FKhE5sPg=; b=TieqCdXZTTg/ 0F+1rhDfxKgcJZFzugGIiPrs1PkdyBFXN/O80bwWQo+2TeiHAxl2r3kDDXYnyYYqY+ppuMuWMODua RtDJlhFQOgOZF8gIHbmBuVI74qGC0nv/HfwOwchL3LwCcZfpzCL2+lODmRPwJxlmiOa28NIOeSpoA pS4kYMpeWTIRugB6l5l6HHn4Mb7TvA2ha5iIL/xLthluqKNmwtZTHT5vRxGYo8Tue9Ituu5WhLkee PPyxv9A/OmpviBONGnP664jLWU62nht0T1D7TT6rpE0dQt5xLT4PWvvBBS1Yqii1MtHTKyRZ0Cm/W xzMHiIdkX0/FovmP6k1OQw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouv8i-0001wd-Du; Tue, 15 Nov 2022 07:34:08 -0500 In-Reply-To: (message from Gabriel on Mon, 14 Nov 2022 11:48:23 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247933 Archived-At: > From: Gabriel > Date: Mon, 14 Nov 2022 11:48:23 -0300 > > diff --git a/lisp/faces.el b/lisp/faces.el > index 09e8110449..4088f4be8a 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -791,9 +791,8 @@ set-face-attribute > color of the face for 3D boxes. STYLE specifies whether a 3D box > should be draw. If STYLE is `released-button', draw a box looking > like a released 3D button. If STYLE is `pressed-button' draw a box > -that appears like a pressed button. If STYLE is nil, the default if > -the property list doesn't contain a style specification, draw a 2D > -box. > +that appears like a pressed button. If STYLE is nil, `flat-button' > +or omitted, draw a 2D box. Thanks, but can you rephrase so that `flat-button' appeared as one of the values for STYLE, with an explicit (not implied) description of what it does? For example, how does `flat-button' affect what COLOR does for the button isn't clear from your suggested text. IOW, what I see in NEWS about this doesn't follow from the text you propose, at least not easily.