From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, 49160@debbugs.gnu.org
Subject: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks
Date: Thu, 12 Jan 2023 09:39:47 +0200 [thread overview]
Message-ID: <83tu0wkxq4.fsf@gnu.org> (raw)
In-Reply-To: <871qo0vkkb.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: larsi@gnus.org, 49160@debbugs.gnu.org, dick.r.chiang@gmail.com
> Date: Wed, 11 Jan 2023 21:16:20 +0000
>
> Eli Zaretskii [2023-01-11 15:22 -0500] wrote:
>
> >> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> >> Cc: Eli Zaretskii <eliz@gnu.org>, 49160@debbugs.gnu.org, dick
> >> <dick.r.chiang@gmail.com>
> >> Date: Wed, 11 Jan 2023 20:13:21 +0000
> >>
> >> Fmake_indirect_buffer continues to run buffer-list-update-hook
> >> regardless of the new argument. Any objections to changing that?
> >
> > buffer-list-update-hook is not a buffer-hook, strictly speaking.
>
> Right, but it's inhibited together with 'strict' buffer-hooks (and
> documented as such) everywhere except for make-indirect-buffer: see
> get-buffer-create, generate-new-buffer, struct buffer, "(elisp) Buffer
> List", "(elisp) Creating Buffers", "(elisp) Buffer Internals", and
> etc/NEWS.28.
>
> In fact, "(elisp) Indirect Buffers" even says about
> make-indirect-buffer:
>
> *Note Creating Buffers, for the meaning of INHIBIT-BUFFER-HOOKS.
>
> Where "(elisp) Creating Buffers" elaborates:
>
> Both functions accept an optional argument INHIBIT-BUFFER-HOOKS. If
> it is non-‘nil’, the buffer they create does not run the hooks
> ‘kill-buffer-hook’, ‘kill-buffer-query-functions’ (*note Killing
> Buffers), and ‘buffer-list-update-hook’ (*note Buffer List). This
> avoids slowing down internal or temporary buffers that are never
> presented to users or passed on to other applications.
>
> So while inhibit-buffer-hooks may be a slightly loose name, I think
> make-indirect-buffer should nevertheless heed it for
> buffer-list-update-hook as well, for the same reason this is done
> everywhere else.
>
> > So I'm not sure we want this. What is the real-life use case behind
> > this request?
>
> The real-life use case is satisfying this bug report+patch from me,
> fixing what seems like a simple oversight, and the ensuing peace of mind
> that I will be grateful for, of course ;).
Stefan, WDYT?
next prev parent reply other threads:[~2023-01-12 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 19:39 bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks dick
2021-06-22 11:41 ` Eli Zaretskii
2021-07-19 16:23 ` Lars Ingebrigtsen
2021-07-19 16:47 ` Eli Zaretskii
2023-01-11 20:13 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 20:23 ` Eli Zaretskii
2023-01-11 21:16 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12 7:39 ` Eli Zaretskii [this message]
2023-01-12 16:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-14 13:20 ` Eli Zaretskii
2023-01-14 14:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-17 11:08 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tu0wkxq4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49160@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).