From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code. Date: Wed, 15 Feb 2023 15:43:34 +0200 Message-ID: <83ttznavsp.fsf@gnu.org> References: <7fe5e80d-761f-cc2d-12a1-65b2b5781c39@umanwizard.com> <9e9ed8043f57226204db@heytings.org> <3b75cf10-6125-608c-a506-323ce09846c7@umanwizard.com> <9e9ed8043fd479390a2a@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36354"; mail-complaints-to="usenet@ciao.gmane.io" Cc: brennan@umanwizard.com, 61521@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 14:44:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSI4u-0009Cn-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 14:44:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSI4r-0006Cs-5V; Wed, 15 Feb 2023 08:44:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSI4p-0006Cf-PJ for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSI4o-0001AX-0w for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSI4n-000164-SL for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 08:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61521 X-GNU-PR-Package: emacs Original-Received: via spool by 61521-submit@debbugs.gnu.org id=B61521.16764686404201 (code B ref 61521); Wed, 15 Feb 2023 13:44:01 +0000 Original-Received: (at 61521) by debbugs.gnu.org; 15 Feb 2023 13:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:58260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSI4m-00015h-2O for submit@debbugs.gnu.org; Wed, 15 Feb 2023 08:44:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSI4j-00015P-O7 for 61521@debbugs.gnu.org; Wed, 15 Feb 2023 08:43:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSI4e-00019G-EH; Wed, 15 Feb 2023 08:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JBo2FeSl6Z2ofARPqCb687j4nTQkGAyIQKCiLmn7oBU=; b=XhdhHcjxW2gd Tb8WKZz5ASZafnHlXvgfK7WISq0DWGHMNM9z9ohWEn9t4XkK9CyRlLvT4xEjN5BoQTijiwhb12KLH DPR41UiGIiSbemA6jnjCicsZLHjZJ624Zj6OoexZLWL13wZv92guxFplxXUZYreV4yGca5Tkv7CwS rnAzT84fHVQ+LjolmDe3I5RrrzTg/BnHGK7vlhyXreGHVFxFIp1JMymikK8WhFjk5+PNxc0jnZWJX q5P7MiWSkB7aLrFQtw1TVdxyhQ2sWiscQNh32Uv6OozPsP3eK3rQYT09pwIGR3NS582eVRNNzBTNG 9qUeXoAG/6wHjgFv4l7fGg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSI4d-0001Al-O9; Wed, 15 Feb 2023 08:43:52 -0500 In-Reply-To: <9e9ed8043fd479390a2a@heytings.org> (message from Gregory Heytings on Wed, 15 Feb 2023 09:00:44 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255702 Archived-At: > Cc: 61521@debbugs.gnu.org > Date: Wed, 15 Feb 2023 09:00:44 +0000 > From: Gregory Heytings > > Thanks. It seems the change you describe is not a recent one: the first > element of the list returned by 'face-list' is 'default' in Emacs 27, 28, > 29 and 30. (This is caused by e3b8ddd500, since which frame faces are > stored in a hash table instead of an alist.) Right. So I wonder whether we should remove the nreverse call in face-set-after-frame-default. WDYT? > Given this, and the fact that the docstring of 'face-list' does not > specify the order in which the faces are returned, it's not clear to me > that there is a bug here. Code that assumes a given order should probably > be fixed. I agree.