From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Thu, 02 Mar 2023 18:32:09 +0200 Message-ID: <83ttz3cdx2.fsf@gnu.org> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35684"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61816@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 17:33:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXlrr-00093a-64 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 17:33:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXlre-0003Hi-Ha; Thu, 02 Mar 2023 11:33:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlrb-0002sj-2S for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 11:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXlra-0006tT-JB for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 11:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXlra-0006AT-Eo for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 11:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.167777474623660 (code B ref 61816); Thu, 02 Mar 2023 16:33:02 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 16:32:26 +0000 Original-Received: from localhost ([127.0.0.1]:58216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlr0-00069Y-0e for submit@debbugs.gnu.org; Thu, 02 Mar 2023 11:32:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlqy-00069M-Ch for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 11:32:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlqs-0006kS-FD; Thu, 02 Mar 2023 11:32:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xA6HXXdxzRtx8yP8St65GUE3NEXOQ9hn3E7+5pnosrU=; b=k+Tvg3DYVMw/T45Hx8Zx S0UYgEUFvYfPYtja45MCALg2NtmrPLxihbeuDApzXPn4d1yRd2nYP5887EmCVFF62q/oj7WC3s6rr +uF99+posOTzHntdo/T86cuYcwudCHmLxKi389PTD9XBwPNoGje6LHvEXI2wEn/jgZOAk+g6ETaol Aze9KH13hFFUnVQhKI/0xzVmt0YI4FI2Ltd5AWpE0ymA5syzoOxI6HIhgV2+dYQI2WLBmAHuNFIRF pFpBUyBRfBjoIqsODNNykEWpfIw26vQka3nVEdc7lRW7PHQG4KxLmNnWbFNtPxKKlQb9MwrqrqCuw zenkap+XjPZq6g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlqr-0002CI-B0; Thu, 02 Mar 2023 11:32:17 -0500 In-Reply-To: <87h6v3jgm8.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 16:51:59 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257171 Archived-At: > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 16:51:59 +0100 > > Manuel Giraud writes: > > > Eli Zaretskii writes: > > > > [...] > > > >> You are right, of course. It just feels strange to need to cater to > >> themes in a core package, when the way themes are supposed to > >> customize Emacs exists and can be used in this case as well. > >> > >> Alternatively, maybe themes should have settings for features such as > >> this one? > > > > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > > official Emacs themes for a start, WDYT? > > ... and in order to be able to use 'custom-theme-set-faces', we could > have a 'doc-view-svg-face' (used only for its foreground and > background). I'm caching you up slowly 😅 Fine by me, that's what I proposed.