From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 61816@debbugs.gnu.org
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Thu, 02 Mar 2023 18:32:09 +0200 [thread overview]
Message-ID: <83ttz3cdx2.fsf@gnu.org> (raw)
In-Reply-To: <87h6v3jgm8.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 16:51:59 +0100)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 61816@debbugs.gnu.org
> Date: Thu, 02 Mar 2023 16:51:59 +0100
>
> Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > [...]
> >
> >> You are right, of course. It just feels strange to need to cater to
> >> themes in a core package, when the way themes are supposed to
> >> customize Emacs exists and can be used in this case as well.
> >>
> >> Alternatively, maybe themes should have settings for features such as
> >> this one?
> >
> > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the
> > official Emacs themes for a start, WDYT?
>
> ... and in order to be able to use 'custom-theme-set-faces', we could
> have a 'doc-view-svg-face' (used only for its foreground and
> background). I'm caching you up slowly 😅
Fine by me, that's what I proposed.
next prev parent reply other threads:[~2023-03-02 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 15:33 bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 12:39 ` Eli Zaretskii
2023-03-02 13:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 13:56 ` Eli Zaretskii
2023-03-02 15:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 15:51 ` Eli Zaretskii
2023-03-02 15:57 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 15:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 16:32 ` Eli Zaretskii [this message]
2023-03-02 18:20 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-09 10:06 ` Eli Zaretskii
2023-03-03 2:28 ` Visuwesh
2023-03-03 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttz3cdx2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61816@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).