From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61785: [PATCH] Add option to keep some columns in dired-hide-details-mode Date: Sat, 04 Mar 2023 14:35:28 +0200 Message-ID: <83ttz0ae3z.fsf@gnu.org> References: <87sfeu3ruh.fsf@gmail.com> <83bklbe4wa.fsf@gnu.org> <871qm5t5h5.fsf@gmail.com> <838rgdar53.fsf@gnu.org> <87edq4pxjn.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12274"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61785-done@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 13:36:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYR7Z-00030N-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 13:36:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYR7M-0005QO-3p; Sat, 04 Mar 2023 07:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYR7K-0005QG-Uu for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 07:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYR7K-0007Wa-MD for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 07:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYR7K-0004VI-4h for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 07:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61785-done@debbugs.gnu.org id=D61785.167793334817291 (code D ref 61785); Sat, 04 Mar 2023 12:36:02 +0000 Original-Received: (at 61785-done) by debbugs.gnu.org; 4 Mar 2023 12:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:35350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYR76-0004Uo-IZ for submit@debbugs.gnu.org; Sat, 04 Mar 2023 07:35:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYR75-0004Ub-01 for 61785-done@debbugs.gnu.org; Sat, 04 Mar 2023 07:35:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYR6z-0007Ra-MM; Sat, 04 Mar 2023 07:35:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WGqGm0koPrLUXEorFtXUprlJ4TcXholGJ4cVh3qGa6c=; b=aU2JI53HHpGX BoKJPtyIR9WEX+OztUGKvu2ZvffrPpKBL1r19VieiVOKtxOafmGsefbqRNgXZIlahEpcSDmuwqmh9 E6WRjLqPGQOzG49ifcLvYiOU6zFPbonl39XPE0ddDcDwMbOkAZ772lBZLzEJGXzYzQ8yB2e8zbn5D TMA2NQOYyXQZ57DGR+J1t+M9xr/6122p6Q4bwQjEy5eTrQ58dapCLuPN4BEanYMymPgmpFji2fmBE hdTNNAWXW/iHFdVUyTGXh4aWcu7nrCFLS5BxvV1d0Yg0GIMudRDVgM/AW3pp1g4bZ19Z/8SDySVsn vh995NYaMdP6SffXHdZSqw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYR6z-0003lR-5e; Sat, 04 Mar 2023 07:35:41 -0500 In-Reply-To: <87edq4pxjn.fsf@gmail.com> (message from Augusto Stoffel on Sat, 04 Mar 2023 12:26:36 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257276 Archived-At: > From: Augusto Stoffel > Cc: 61785-done@debbugs.gnu.org > Date: Sat, 04 Mar 2023 12:26:36 +0100 > > On Sat, 4 Mar 2023 at 09:54, Eli Zaretskii wrote: > > >> From: Augusto Stoffel > >> Cc: 61785-done@debbugs.gnu.org > >> Date: Sat, 04 Mar 2023 07:07:02 +0100 > >> > >> I think I would rather revert the commit until someone comes up with a > >> better idea, if you don't mind. > > > > I'm not sure I see a problem with counting columns. > > > > What is the harm of keeping the commit on master? If we get > > complaints about it, we have ample time to remove the feature when and > > if we get those complaints. > > The problem is that the code asssumes the columns are right-aligned, > which is not true for user and group. So for instance this listing: > > drwx------. 43 augusto augusto 69632 Mar 4 12:21 . > drwxr-xr-x. 4 root root 4096 Aug 9 2022 .. > drwx------. 171 augusto augusto 12288 Feb 27 11:52 .cache > > will get abridged like this: > > 69632 Mar 4 12:21 . > 4096 Aug 9 2022 .. > 12288 Feb 27 11:52 .cache > > But if you don't mind that, we can keep the code and see if someone > finds a nice way to deal with it. We could perhaps mention the caveat with right-aligned columns to the doc string, and expect users to avoid those columns?