From: Eli Zaretskii <eliz@gnu.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 61785-done@debbugs.gnu.org
Subject: bug#61785: [PATCH] Add option to keep some columns in dired-hide-details-mode
Date: Sat, 04 Mar 2023 14:35:28 +0200 [thread overview]
Message-ID: <83ttz0ae3z.fsf@gnu.org> (raw)
In-Reply-To: <87edq4pxjn.fsf@gmail.com> (message from Augusto Stoffel on Sat, 04 Mar 2023 12:26:36 +0100)
> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: 61785-done@debbugs.gnu.org
> Date: Sat, 04 Mar 2023 12:26:36 +0100
>
> On Sat, 4 Mar 2023 at 09:54, Eli Zaretskii wrote:
>
> >> From: Augusto Stoffel <arstoffel@gmail.com>
> >> Cc: 61785-done@debbugs.gnu.org
> >> Date: Sat, 04 Mar 2023 07:07:02 +0100
> >>
> >> I think I would rather revert the commit until someone comes up with a
> >> better idea, if you don't mind.
> >
> > I'm not sure I see a problem with counting columns.
> >
> > What is the harm of keeping the commit on master? If we get
> > complaints about it, we have ample time to remove the feature when and
> > if we get those complaints.
>
> The problem is that the code asssumes the columns are right-aligned,
> which is not true for user and group. So for instance this listing:
>
> drwx------. 43 augusto augusto 69632 Mar 4 12:21 .
> drwxr-xr-x. 4 root root 4096 Aug 9 2022 ..
> drwx------. 171 augusto augusto 12288 Feb 27 11:52 .cache
>
> will get abridged like this:
>
> 69632 Mar 4 12:21 .
> 4096 Aug 9 2022 ..
> 12288 Feb 27 11:52 .cache
>
> But if you don't mind that, we can keep the code and see if someone
> finds a nice way to deal with it.
We could perhaps mention the caveat with right-aligned columns to the
doc string, and expect users to avoid those columns?
prev parent reply other threads:[~2023-03-04 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 11:30 bug#61785: [PATCH] Add option to keep some columns in dired-hide-details-mode Augusto Stoffel
2023-03-02 12:04 ` Eli Zaretskii
2023-03-04 6:07 ` Augusto Stoffel
2023-03-04 7:54 ` Eli Zaretskii
2023-03-04 11:26 ` Augusto Stoffel
2023-03-04 12:35 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttz0ae3z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61785-done@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).