From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Tue, 02 May 2023 18:16:35 +0300 Message-ID: <83ttwun4q4.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <87a5zt2emd.fsf@betli.tmit.bme.hu> <87fs9l9bim.fsf@posteo.net> <87y1n3zsro.fsf@posteo.net> <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29354"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Tony Zorman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 02 17:17:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptrl4-0007NO-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 May 2023 17:17:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptrkn-0000Fs-TI; Tue, 02 May 2023 11:17:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptrkU-0000Ee-7I for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 11:17:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptrkT-00068p-Vk for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 11:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptrkT-0007SS-Qk for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2023 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168304056228584 (code B ref 60418); Tue, 02 May 2023 15:17:01 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 2 May 2023 15:16:02 +0000 Original-Received: from localhost ([127.0.0.1]:44836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptrjV-0007Qk-R4 for submit@debbugs.gnu.org; Tue, 02 May 2023 11:16:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptrjT-0007Q9-Do for 60418@debbugs.gnu.org; Tue, 02 May 2023 11:16:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptrjM-0005Yx-6l; Tue, 02 May 2023 11:15:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S728GrxwQPiPzrwp7AYbqBsyzdkmie1/pJjOV7tAjOw=; b=dYRHMDPhPgq0 hcdBSPdyo/kZ0m2tQZ20bQ8p50M+LnmkFEsVG7pMis340BV2j80dqMC+TdJVVfKKb+U5MTCwW+u6z fHPJOaRWGALRgkym5OVznhQ8I4JCBWbo4O81g/aTWKFCsdfGZ4944EuWj9oMRo+lZdqPPbZFo9pjC AF/ql/Hu+gEaxFFF/EmFqi8pOQDZNHlv+wsLULLfw4o9G5cLN29Z9hAEv8ehHhCmlodrKXzJe4fGW 3CJull9rHSkqxnTyb9UAvXq6ny1JVTLyeabFYgw0Ir6rBmli8TrbXvYtRJ8e1hWJNBOmxnuCeFQSO Z3zFVBN1R5Zo66h9RM9iwA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptrjL-0001Me-LE; Tue, 02 May 2023 11:15:51 -0400 In-Reply-To: <87h6suolt2.fsf@hyperspace> (message from Tony Zorman on Tue, 02 May 2023 16:22:17 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260939 Archived-At: > From: Tony Zorman > Cc: philipk@posteo.net, 60418@debbugs.gnu.org, felician.nemeth@gmail.com, > stefankangas@gmail.com > Date: Tue, 02 May 2023 16:22:17 +0200 > > On Tue, May 02 2023 15:40, Eli Zaretskii wrote: > >> +@code{package-vc-install}. Notably -- even when not specified -- > >> +@code{:rev} defaults to checking out the last release of the package. > >> +You can use @code{:rev :newest} to check out the latest commit. > >> + > >> +For example, > >> + > >> +@example > >> +@group > >> +(use-package bbdb > >> + :vc (:url "https://git.savannah.nongnu.org/git/bbdb.git" > >> + :rev :newest)) > >> +@end group > >> +@end example > >> + > >> +would try -- by invoking @code{package-vc-install} -- to install the > >> +latest commit of the package @code{foo} from the specified remote. > > ^^^ > > A typo there. > > > > Also, you say above "the latest release", but then "the latest > > commit". These two are not the same, and in fact I think talking > > about "release" here is misleading, since you actually mean "commit". > > For the same reason, I think the text should explain how to indicate a > > commit that is not the latest one, because that is also not > > self-evident, especially since the upstream VCS is not necessarily > > Git. > > I think the terminology of commit and release I use here are consistent, > though maybe the wording is perhaps not entirely clear. Not in my eyes, it isn't. E.g., look at any GitHub repository: there are "commits" there, and there are "releases", and they are not the same. > If :rev is not explicitly given, then :vc falls back to calling > package-vc-install (in the case of a non-local upstream) with the > :last-release keyword in place of its REV argument (which is called a > revision in the docs). Since package-vc.el freely calls :last-release a > release of a package, I figured this terminology is appropriate here. It > is only when :rev :newest is given that I talk about commits, which > should also be accurate. Or perhaps you mean that I mistakenly talk > about the latest release in some other place that I've overlooked just > now? All I know is that when I've read the documentation you wrote, I asked myself "what is meant by 'release' here?" I found the answer when you later wrote "last commit". Are you talking about commits? More generally, what kind of "release IDs" does :rev accept as its valid value? I understand that the same confusion could exist elsewhere, but that doesn't mean we should proliferate it or even live with what we have. We should instead clarify this in every place where we use this terminology. So let's figure out what are these "releases", and then let's examine the existing and the new documentation and see if we need to get our terminology right there. Thanks.