From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63283: Emacs crash within fontset Date: Sun, 07 May 2023 09:48:48 +0300 Message-ID: <83ttwoeiwf.fsf@gnu.org> References: <83wn1njswh.fsf@gnu.org> <835y95hicm.fsf@gnu.org> <7viubPQBitOqW2lvRK1P_aP6NjiS05pc86HGIH8yUyCZGabZgL5Hb3YAdm9efSCsxPb7yxW55zGhfZfE2PUjkZesUSharobfMDC3-JTEL1E=@protonmail.com> <835y95fe64.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3649"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63283@debbugs.gnu.org To: Seppo Ronkainen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 08:48:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvYCQ-0000ka-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 08:48:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvYBn-00047n-8R; Sun, 07 May 2023 02:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvYBf-00047O-7V for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 02:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvYBe-00051z-Sg for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 02:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvYBe-0008CV-GS for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 02:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 06:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63283 X-GNU-PR-Package: emacs Original-Received: via spool by 63283-submit@debbugs.gnu.org id=B63283.168344208131507 (code B ref 63283); Sun, 07 May 2023 06:48:02 +0000 Original-Received: (at 63283) by debbugs.gnu.org; 7 May 2023 06:48:01 +0000 Original-Received: from localhost ([127.0.0.1]:36231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYBc-0008C4-Hx for submit@debbugs.gnu.org; Sun, 07 May 2023 02:48:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYBZ-0008B5-00 for 63283@debbugs.gnu.org; Sun, 07 May 2023 02:47:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvYBT-00051W-My; Sun, 07 May 2023 02:47:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=R1UMXcpWA5Ay6GKkid1FxDv8BOhZbBeHU0vqWrCbx8s=; b=K2odQuRsLTF+ vJbDTGi5SrYFrhc20tENNd14BcdEi85/rmbaePO8t8GqQ51qIwnZ5IUQz3CJqeI2kHrRrwljiSD5F ZEsoTDomTibnxmt8qXEDlewcp5KJRQUEBk+b9yEsYT4iliSE4qqGqVV2WjfpO28j1WkXyhwg4Ne6q avoN6wpYa2bbgfJeo3HTZOCkizurOM12dGGXR7Jidj9ZBp5HgrFqStyWgLErQcr2cYIX73pqOaTBu p41p+0NnpraBB+h7Z+423b/KRqE8RLZKQfOBU9fSJB/4UheLygJE7x6UwOby1OZw0VaEwWKPqlgHP 73G26gfuzDniGNo2voWttA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvYBT-0004im-6Q; Sun, 07 May 2023 02:47:51 -0400 In-Reply-To: (message from Seppo Ronkainen on Sat, 06 May 2023 22:36:35 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261235 Archived-At: > Date: Sat, 06 May 2023 22:36:35 +0000 > From: Seppo Ronkainen > Cc: 63283@debbugs.gnu.org > > (gdb) frame 2 > #2 0x00000055559233c4 in face_for_char (f=0x55564c8470, face=0x5556292b90, c=12302, pos=1, object=XIL(0)) at fontset.c:970 > 970 eassert (fontset_id_valid_p (face->fontset)); > (gdb) info locals > fontset = XIL(0) > rfont_def = XIL(0x555605b2b8) > charset = XIL(0x300effff7380) > face_id = 85 > id = 1432078920 > (gdb) print font_driver_list > $1 = (struct font_driver_list *) 0x55560d77e0 > (gdb) print f->font_driver_list > $2 = (struct font_driver_list *) 0x5556274ae0 > (gdb) frame 3 > #3 0x00000055555bd308 in FACE_FOR_CHAR (f=0x55564c8470, face=0x5556292b90, character=12302, pos=1, object=XIL(0)) at dispextern.h:1911 > (gdb) p face->font > $5 = (struct font *) 0x0 > (gdb) p face->fontset > $6 = -1 > (gdb) q Thanks. If you apply the patch below, does it avoid the abort? > relevant commit ? > 3c0dda2663e38635163f0fd6c19748c6eba1c3c8 > Avoid asserting for fontset validity before it is used No, I don't think so. We'd just abort earlier in that function. diff --git a/src/fontset.c b/src/fontset.c index f196dee..e004cd9 100644 --- a/src/fontset.c +++ b/src/fontset.c @@ -967,6 +967,9 @@ face_for_char (struct frame *f, struct face *face, int c, #endif } + if (face->fontset < 0 && !face->font) + return face->id; + eassert (fontset_id_valid_p (face->fontset)); fontset = FONTSET_FROM_ID (face->fontset); eassert (!BASE_FONTSET_P (fontset));