From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Fri, 02 Jun 2023 09:32:58 +0300 Message-ID: <83ttvqbch1.fsf@gnu.org> References: <86wn10e1wl.fsf@mail.linkov.net> <482a1ebc-165c-a0a4-98c0-5c404d1b1d0d@gutov.dev> <86jzwyxnxb.fsf@mail.linkov.net> <86o7m91z22.fsf@mail.linkov.net> <86pm6py6k4.fsf@mail.linkov.net> <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26249"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 63648@debbugs.gnu.org, sbaugh@janestreet.com To: Juri Linkov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 02 08:33:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4yLj-0006Z8-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Jun 2023 08:33:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4yLb-0002Fz-K2; Fri, 02 Jun 2023 02:33:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4yLO-0002EO-JD for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 02:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4yLO-0002PP-BH for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 02:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4yLO-0007D9-2Y for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 02:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2023 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.168568754127670 (code B ref 63648); Fri, 02 Jun 2023 06:33:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 2 Jun 2023 06:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:38980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4yKi-0007CC-SL for submit@debbugs.gnu.org; Fri, 02 Jun 2023 02:32:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4yKe-0007Bx-Qi for 63648@debbugs.gnu.org; Fri, 02 Jun 2023 02:32:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4yKX-0002Gn-V4; Fri, 02 Jun 2023 02:32:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xYVZ2WKHpVM1vL0KJpH0Cw4JYdaAlONzz3wibMxKajY=; b=PobKP0oapVYv 9LUAYnFrxw9dhGBVpji98ovGUw5e1bmNz4lfhL/n7WSdUhD3Qi5JBST9+lZ45D9KKov7pigdCGSQq JPMgPdk6/a9/+1LOQM82RuQHyruSmtfv6Xuob18nNhIOEwJOFVOratgsYMd9dj5agXb8XOiZAN5HG rYDryxMCnMJJKowUUMqo17huMapnwRbdq3535tSztG6SYF0O4YZnEmfaUtVXjbqhnZho3j6WFc0Nl D6qgrRirTJ9yE2g/YZIgxX4CmxniLObp1r2bCYYKOsbNUTSSTgiaVkbbNwWaEQ4ra5QYwQJPrsMMQ ssg4JpmtEYVRjSupfNUXLA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4yKX-00067Y-II; Fri, 02 Jun 2023 02:32:09 -0400 In-Reply-To: <86cz2f7bvo.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 01 Jun 2023 19:05:07 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262735 Archived-At: > Cc: Spencer Baugh , 63648@debbugs.gnu.org > From: Juri Linkov > Date: Thu, 01 Jun 2023 19:05:07 +0300 > > And indeed with the following patch replacing the current definition of > 'project-switch-project' with just: > > (defun project-switch-project (dir) > (interactive (list (funcall project-prompter))) > (setq next-default-directory dir)) > > 'C-x p p (select project ...) RET M-& pwd RET' confirms that > the command runs in the selected project directory. > Whereas the original buffer keeps its previous buffer-local value > of 'default-directory'. > > diff --git a/src/buffer.c b/src/buffer.c > index 0c46b201586..ca81db21894 100644 > --- a/src/buffer.c > +++ b/src/buffer.c > @@ -5360,6 +5360,10 @@ syms_of_buffer (void) > these names start with `/' or `~' and end with `/'. > To interactively change the default directory, use command `cd'. */); > > + DEFVAR_LISP ("next-default-directory", Vnext_default_directory, > + doc: /* Default directory for the next command. */); > + Vnext_default_directory = Qnil; > + > DEFVAR_PER_BUFFER ("auto-fill-function", &BVAR (current_buffer, auto_fill_function), > Qnil, > doc: /* Function called (if non-nil) to perform auto-fill. > diff --git a/src/keyboard.c b/src/keyboard.c > index 14c55666768..dfe939750c9 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -1500,7 +1500,19 @@ command_loop_1 (void) > update_redisplay_ticks (0, NULL); > display_working_on_window_p = false; > > + Lisp_Object next_dir = Vnext_default_directory; > + specpdl_ref count = SPECPDL_INDEX (); > + if (!NILP (next_dir)) > + specbind (Qdefault_directory, next_dir); > + > call1 (Qcommand_execute, Vthis_command); > + > + if (!NILP (next_dir)) > + { > + unbind_to (count, Qnil); > + Vnext_default_directory = Qnil; > + } > + > display_working_on_window_p = false; > > #ifdef HAVE_WINDOW_SYSTEM What will this do when a command is invoked via call-interactively?