From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Thu, 27 Jul 2023 08:28:58 +0300 Message-ID: <83tttpncrp.fsf@gnu.org> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <83wmynnd1e.fsf@gnu.org> <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5908"; mail-complaints-to="usenet@ciao.gmane.io" Cc: info@protesilaos.com, 64799@debbugs.gnu.org, philipk@posteo.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 27 07:52:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOtv5-0001Dn-KT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jul 2023 07:52:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOtYf-0003Q9-9I; Thu, 27 Jul 2023 01:29:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOtYc-0003P7-92 for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 01:29:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOtYc-0004f6-0T for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 01:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOtYb-0005BB-SE for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 01:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2023 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169043569819856 (code B ref 64799); Thu, 27 Jul 2023 05:29:01 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 27 Jul 2023 05:28:18 +0000 Original-Received: from localhost ([127.0.0.1]:40521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOtXt-0005AC-ST for submit@debbugs.gnu.org; Thu, 27 Jul 2023 01:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOtXr-00059y-4J for 64799@debbugs.gnu.org; Thu, 27 Jul 2023 01:28:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOtXl-0004YL-7U; Thu, 27 Jul 2023 01:28:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LRhJPurGXKgC6lGuGJdHjGJdg5i5aGi3McC1nm5tbMo=; b=TSY0Xg/24wS6 iYrnozOrx3R05TFCiyxhfMurSB8LINP/Us2CHV7TTUINweOoRmYpk8JV2ixJ7mPDTpC9z3M5AscQc F+cSFYl/T0qks2a4PGgfZ6wwKobJR07xxW3nGhaF+PYnURIaw4wTGvSsJbXlE9hD5ls0JV0TyAjNV AUgyJilv1PLoLk6rqqBxOcNHq7nSQ/S09tgRZEzG+b1rGWYsB/MKidDBVIEZQRxDrMTg3fe/sLp7v WqFy8TvO3bLICv5mZ5f/T2tfOr1OslEu8XFiyP1s/OhPY089sEnL5AKkgLKEMaqyot6qK8CIK+pFe ABY6VcCR8aXaQ1iFgukjgg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOtXk-0002Pg-N8; Thu, 27 Jul 2023 01:28:09 -0400 In-Reply-To: <11d47a2d-c068-b40f-ad86-6025201e8484@gutov.dev> (message from Dmitry Gutov on Thu, 27 Jul 2023 04:01:17 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266160 Archived-At: > Date: Thu, 27 Jul 2023 04:01:17 +0300 > Cc: philipk@posteo.net, 64799@debbugs.gnu.org > From: Dmitry Gutov > > On 26/07/2023 14:10, Eli Zaretskii wrote: > > Beware: the 'bold' face changes the metrics of the font glyphs (wrt > > the 'medium' variant), and at least with some fonts could cause a > > small 1- or 2-pixel vertical resize of the mini-window, which is > > generally distracting and even annoying. > > Only non-monospaced font, though, right? Or ones without a 'bold' variant. No, not only those. I'm talking about the _vertical_ metrics, so whether the font is monospaced is not relevant. Try marking files for deletion in Dired, and you will see that, at least with some fonts and some sizes. Here on MS-Windows the default face's font (Courier New) does that, for some sizes of the font. I have customized eldoc-highlight-function-argument to use 'underline' instead of 'bold' for that very reason. > Anyway, we're talking about switching from 'bold' to 'help-key-binding', > which uses the default weight. That's fine. I was under the impression that 'bold' is also being considered, and wanted to warn about this.