From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65245: Possible code removal in eshell/diff (em-unix.el) Date: Sun, 13 Aug 2023 20:54:48 +0300 Message-ID: <83ttt2bzfb.fsf@gnu.org> References: <00c46fb4ab8972714de3d338acbd5040@unbit.co.uk> <831qg7cbit.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37951"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs@unbit.co.uk, 65245@debbugs.gnu.org, stefankangas@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 13 19:55:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVFJ5-0009a6-6C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Aug 2023 19:55:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVFIu-0003mg-HK; Sun, 13 Aug 2023 13:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVFIs-0003mC-PI for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 13:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVFIs-0003hg-GE for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 13:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVFIs-0008Su-9V for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 13:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2023 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65245 X-GNU-PR-Package: emacs Original-Received: via spool by 65245-submit@debbugs.gnu.org id=B65245.169194929832528 (code B ref 65245); Sun, 13 Aug 2023 17:55:02 +0000 Original-Received: (at 65245) by debbugs.gnu.org; 13 Aug 2023 17:54:58 +0000 Original-Received: from localhost ([127.0.0.1]:60307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVFIo-0008SZ-FU for submit@debbugs.gnu.org; Sun, 13 Aug 2023 13:54:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVFIm-0008SN-P1 for 65245@debbugs.gnu.org; Sun, 13 Aug 2023 13:54:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVFIg-0003fs-C3; Sun, 13 Aug 2023 13:54:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ox5X2IB/sbPv4QPt0tS5A5b2RIp6goAPLNR7g2tYOxM=; b=C5lhAdC0JzPY T+9+VHnKCCCZXUQ4ivTzJD6ZyrDe4Je136+9DHfBte41/DQhLvZWV/9+7QstxnhghQoJgvQ9dO5nY WKONrKNzUuku3tTB9yb0cie7fo82A1/DTUgksGzVLKo7gt8SxyylfqyjuHC6ImN0G7jMtGMHa+7Pq 9D/F1JiEME0CxuVMofqj3a10O6oHgF/a/1XdYwcBXuerhePZKZfDM3ys7ZOZWRdNA5cVA5oxu0Ef/ dHeyHnT4eL6836uRItjh1AO8fXbUJDBliuGM1FUhnHaPMRdUoNbWHN3Rfxr5uQnaZUYGMP0AolBgu fQsICPvVnjNjrm8QYJwLHQ==; In-Reply-To: (message from Jim Porter on Sun, 13 Aug 2023 10:32:34 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267380 Archived-At: > Date: Sun, 13 Aug 2023 10:32:34 -0700 > Cc: emacs@unbit.co.uk, 65245@debbugs.gnu.org > From: Jim Porter > > On 8/13/2023 9:49 AM, Stefan Kangas wrote: > > Eli Zaretskii writes: > > > >> It would have been prudent to wait for the Eshell maintainer > > > > Thanks, I'll keep that in mind for next time. Kudos to Jim for taking > > on the work of maintaining eshell! > > Thanks, this all looks right to me, though I haven't tested it out in > practice. For minor changes like this (especially for code that long > predates my involvement), I don't think there's any real harm in others > committing changes without first getting an ok from me. Still, it's > probably reasonable to be on the safe side and let me take a look first > (unless I'm nonresponsive for a while, of course). Changes in any Emacs package that has an active maintainer should be coordinated with that maintainer. The only exceptions are obvious fixes like typos, clear omissions, and other such stuff.