From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs@unbit.co.uk, 65245@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#65245: Possible code removal in eshell/diff (em-unix.el)
Date: Sun, 13 Aug 2023 20:54:48 +0300 [thread overview]
Message-ID: <83ttt2bzfb.fsf@gnu.org> (raw)
In-Reply-To: <a04f4495-fa93-8150-b86e-11202a45587f@gmail.com> (message from Jim Porter on Sun, 13 Aug 2023 10:32:34 -0700)
> Date: Sun, 13 Aug 2023 10:32:34 -0700
> Cc: emacs@unbit.co.uk, 65245@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 8/13/2023 9:49 AM, Stefan Kangas wrote:
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> It would have been prudent to wait for the Eshell maintainer
> >
> > Thanks, I'll keep that in mind for next time. Kudos to Jim for taking
> > on the work of maintaining eshell!
>
> Thanks, this all looks right to me, though I haven't tested it out in
> practice. For minor changes like this (especially for code that long
> predates my involvement), I don't think there's any real harm in others
> committing changes without first getting an ok from me. Still, it's
> probably reasonable to be on the safe side and let me take a look first
> (unless I'm nonresponsive for a while, of course).
Changes in any Emacs package that has an active maintainer should be
coordinated with that maintainer. The only exceptions are obvious
fixes like typos, clear omissions, and other such stuff.
next prev parent reply other threads:[~2023-08-13 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 10:49 bug#65245: Possible code removal in eshell/diff (em-unix.el) Richard Hopkins
2023-08-13 13:18 ` Stefan Kangas
2023-08-13 13:33 ` Eli Zaretskii
2023-08-13 16:49 ` Stefan Kangas
2023-08-13 17:32 ` Jim Porter
2023-08-13 17:54 ` Eli Zaretskii [this message]
2023-08-14 7:26 ` Michael Albinus
2023-08-14 9:07 ` Stefan Kangas
2023-08-18 4:33 ` Amin Bandali
2023-08-19 10:54 ` Stefan Kangas
2023-08-14 12:04 ` Eli Zaretskii
2023-08-15 3:02 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttt2bzfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65245@debbugs.gnu.org \
--cc=emacs@unbit.co.uk \
--cc=jporterbugs@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).