From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer Date: Mon, 25 Sep 2023 19:39:25 +0300 Message-ID: <83ttri1a2q.fsf@gnu.org> References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> <83y1gu1iv5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66181@debbugs.gnu.org, kediez@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 25 18:41:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkoe2-0008RE-FX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Sep 2023 18:41:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkodf-0006wS-5u; Mon, 25 Sep 2023 12:40:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkodd-0006vr-FN for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 12:40:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkodd-0005Hc-77 for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 12:40:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkodp-0001A5-Lu for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 12:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2023 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66181 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 66181-submit@debbugs.gnu.org id=B66181.16956600214401 (code B ref 66181); Mon, 25 Sep 2023 16:41:01 +0000 Original-Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 16:40:21 +0000 Original-Received: from localhost ([127.0.0.1]:46512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkodB-00018v-Af for submit@debbugs.gnu.org; Mon, 25 Sep 2023 12:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkod8-00018e-Lt for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 12:40:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkocq-00051p-AB; Mon, 25 Sep 2023 12:40:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3t2V1SefkS2CDIGF9Lz2aSPLBkulD/5Emj5PIl9iNPY=; b=LhXuuuNkCqob xntMSb4UnFS30GC1dK/GHF+xQnXZKGfKtwmY3FqIbdJgIlRm4+ZwEPkuQVCZrQAKEOLb0nD5JbgmV MoHOHv1DXrnAjcozhbUl8uZFmlcTJ+gzPaLOT+xp3qEKKaPLkbTj/aTlE9fw1s8tD2X3PJ0B25PaR mkpoQvVXTdBeLUNH8pQDRs3UWQGE4dx5eJW5eriMmbe1woKR9xA52IR0PspLm5Ru7WvxieM99IyRm S7V4B25o/AotaAm/WvZUF2VunYPJB1k4wHEnmviJLqo4ihPyz6bgh/aP8P0Rh/iiXio3LHjexrJNy zI74R1XHis/6d2jslwPP1A==; In-Reply-To: (message from Stefan Monnier on Mon, 25 Sep 2023 09:52:36 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271342 Archived-At: > From: Stefan Monnier > Cc: kediez@gmail.com, 66181@debbugs.gnu.org > Date: Mon, 25 Sep 2023 09:52:36 -0400 > > >> > Stefan, do we have any safe means of running the hooks in this case? > >> > I thought about running the buffer-local values of before- and > >> > after-change-functions by hand from occur-after-change-function, > >> > skipping the t entry, but I'm not sure this is safe. It is certainly > >> > messy, so if there's a more elegant way, I'd like to know. > >> > >> Arguably, the `inhibit-modification-hooks` let-binding that surrounds > >> code run from within modification hooks should be buffer-local, which > >> would solve these problems, AFAIK. > > > > Not sure I understand: we let-bind inhibit-modification-hooks in C, > > via specbind, and that binds the global value, since > > inhibit-modification-hooks is not a per-buffer variable. Or am I > > missing something. > > You're right that's what we currently do. > > > Do you mean we should add a new specbind_local function that makes > > only a buffer-local let-binding? > > For example, yes. Or we could call `Fmake_local_variable` before the > `specbind`, or we could make `inhibit-modification-hooks` into one of > those vars that are "really always" buffer-local, like `major-mode`, > `buffer-file-name` and a few others. Would it work (and be okay) to make inhibit-modification-hooks buffer-local in a buffer in which occur-edit-mode is turned on?