unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
@ 2012-02-27 19:18 Johan Bockgård
  2012-02-27 20:36 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Bockgård @ 2012-02-27 19:18 UTC (permalink / raw)
  To: 10902


emacs -Q

Eval

    (progn
      (pop-to-buffer (get-buffer-create "*foo*"))
      (dotimes (n 5) (insert "x\n"))
      (goto-char (point-min))
      (setq scroll-margin 100)
      (set-window-text-height nil (+ 5 2)))

Press `M->'

  => Point is displayed one line below the end of the buffer.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
  2012-02-27 19:18 bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin Johan Bockgård
@ 2012-02-27 20:36 ` Eli Zaretskii
  2012-02-27 22:15   ` Johan Bockgård
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2012-02-27 20:36 UTC (permalink / raw)
  To: Johan Bockgård; +Cc: 10902

> From: Johan Bockgård <bojohan@gnu.org>
> Date: Mon, 27 Feb 2012 20:18:09 +0100
> 
> 
> emacs -Q
> 
> Eval
> 
>     (progn
>       (pop-to-buffer (get-buffer-create "*foo*"))
>       (dotimes (n 5) (insert "x\n"))
>       (goto-char (point-min))
>       (setq scroll-margin 100)
>       (set-window-text-height nil (+ 5 2)))
> 
> Press `M->'
> 
>   => Point is displayed one line below the end of the buffer.

The same happens in Emacs 23, so this isn't a regression in Emacs 24.

I will take a look soon.  Thanks for reporting this.

P.S.  Is there a real-life use-case behind this?  I mean, setting a
scroll margin that is wider than the window sounds... how should I put
it... weird, no?






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
  2012-02-27 20:36 ` Eli Zaretskii
@ 2012-02-27 22:15   ` Johan Bockgård
  2012-03-02 11:40     ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Bockgård @ 2012-02-27 22:15 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 10902

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Johan Bockgård <bojohan@gnu.org>
>> Date: Mon, 27 Feb 2012 20:18:09 +0100
>> 
>> 
>> emacs -Q
>> 
>> Eval
>> 
>>     (progn
>>       (pop-to-buffer (get-buffer-create "*foo*"))
>>       (dotimes (n 5) (insert "x\n"))
>>       (goto-char (point-min))
>>       (setq scroll-margin 100)
>>       (set-window-text-height nil (+ 5 2)))
>> 
>> Press `M->'
>> 
>>   => Point is displayed one line below the end of the buffer.
>
> The same happens in Emacs 23, so this isn't a regression in Emacs 24.

Yes, I noticed that after sending the report. Actually, it happens
already in Emacs 21.

(BTW, I cannot reproduce it in emacs -nw.)

> I will take a look soon.  Thanks for reporting this.
>
> P.S.  Is there a real-life use-case behind this?  I mean, setting a
> scroll margin that is wider than the window sounds... how should I put
> it... weird, no?

The precise value of scroll-margin is not important. It happens for any
value > 1.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
  2012-02-27 22:15   ` Johan Bockgård
@ 2012-03-02 11:40     ` Eli Zaretskii
  2012-03-03 17:28       ` Johan Bockgård
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2012-03-02 11:40 UTC (permalink / raw)
  To: Johan Bockgård; +Cc: 10902

> From: Johan Bockgård <bojohan@gnu.org>
> Cc: 10902@debbugs.gnu.org
> Date: Mon, 27 Feb 2012 23:15:55 +0100
> 
> > I will take a look soon.  Thanks for reporting this.
> >
> > P.S.  Is there a real-life use-case behind this?  I mean, setting a
> > scroll margin that is wider than the window sounds... how should I put
> > it... weird, no?
> 
> The precise value of scroll-margin is not important. It happens for any
> value > 1.

But only if the window height is 2 lines more than the buffer line
count, according to my testing.

Anyway, I think I fixed this (in revision 107481 on the trunk).
Please see if there are any leftovers after that fix.

Thanks.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
  2012-03-02 11:40     ` Eli Zaretskii
@ 2012-03-03 17:28       ` Johan Bockgård
  2012-03-03 19:06         ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Bockgård @ 2012-03-03 17:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 10902

Eli Zaretskii <eliz@gnu.org> writes:

>> > I will take a look soon.  Thanks for reporting this.
>> >
>> > P.S.  Is there a real-life use-case behind this?  I mean, setting a
>> > scroll margin that is wider than the window sounds... how should I put
>> > it... weird, no?
>> 
>> The precise value of scroll-margin is not important. It happens for any
>> value > 1.
>
> But only if the window height is 2 lines more than the buffer line
> count, according to my testing.

Mine too.

> Anyway, I think I fixed this (in revision 107481 on the trunk).
> Please see if there are any leftovers after that fix.

It fixes the problem for me. Thanks.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin
  2012-03-03 17:28       ` Johan Bockgård
@ 2012-03-03 19:06         ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2012-03-03 19:06 UTC (permalink / raw)
  To: Johan Bockgård; +Cc: 10902-done

> From: Johan Bockgård <bojohan@gnu.org>
> Cc: 10902@debbugs.gnu.org
> Date: Sat, 03 Mar 2012 18:28:41 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> > I will take a look soon.  Thanks for reporting this.
> >> >
> >> > P.S.  Is there a real-life use-case behind this?  I mean, setting a
> >> > scroll margin that is wider than the window sounds... how should I put
> >> > it... weird, no?
> >> 
> >> The precise value of scroll-margin is not important. It happens for any
> >> value > 1.
> >
> > But only if the window height is 2 lines more than the buffer line
> > count, according to my testing.
> 
> Mine too.
> 
> > Anyway, I think I fixed this (in revision 107481 on the trunk).
> > Please see if there are any leftovers after that fix.
> 
> It fixes the problem for me. Thanks.

Thanks, I'm closing the bug.






^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-03-03 19:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-27 19:18 bug#10902: 24.0.93; Point displayed after end of buffer with scroll-margin Johan Bockgård
2012-02-27 20:36 ` Eli Zaretskii
2012-02-27 22:15   ` Johan Bockgård
2012-03-02 11:40     ` Eli Zaretskii
2012-03-03 17:28       ` Johan Bockgård
2012-03-03 19:06         ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).