From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11850: bug#11813: bug#11850: crash (null font) running emacs built from git Date: Thu, 05 Jul 2012 19:54:59 +0300 Message-ID: <83sjd62lng.fsf@gnu.org> References: <831uks6bvy.fsf@gnu.org> <83y5n04wno.fsf@gnu.org> <83d34b4hdq.fsf@gnu.org> <831ukr45gh.fsf@gnu.org> <83y5my2vp8.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1341507327 13430 80.91.229.3 (5 Jul 2012 16:55:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 5 Jul 2012 16:55:27 +0000 (UTC) Cc: 11850@debbugs.gnu.org, 11813@debbugs.gnu.org To: Left Right , Yotam Medini =?UTF-8?Q?=D7=99=D7=95=D7=AA=D7=9D_?= =?UTF-8?Q?=D7=9E=D7=93=D7=99=D7=A0=D7=99?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 05 18:55:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SmpKu-0006s0-6e for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2012 18:55:24 +0200 Original-Received: from localhost ([::1]:52104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmpKt-0003jX-9x for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2012 12:55:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmpKm-0003ec-AL for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 12:55:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmpKg-0002tk-6Z for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 12:55:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmpKg-0002tf-3A for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 12:55:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SmpPO-0003rZ-Vx for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 13:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jul 2012 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11850-submit@debbugs.gnu.org id=B11850.134150759914768 (code B ref 11850); Thu, 05 Jul 2012 17:00:02 +0000 Original-Received: (at 11850) by debbugs.gnu.org; 5 Jul 2012 16:59:59 +0000 Original-Received: from localhost ([127.0.0.1]:50841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmpPL-0003q4-Ct for submit@debbugs.gnu.org; Thu, 05 Jul 2012 12:59:59 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:55348) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmpPI-0003pr-MB; Thu, 05 Jul 2012 12:59:57 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M6P00I005M00O00@a-mtaout21.012.net.il>; Thu, 05 Jul 2012 19:54:57 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M6P00H4J5NKQ8C0@a-mtaout21.012.net.il>; Thu, 05 Jul 2012 19:54:57 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61621 Archived-At: > Date: Thu, 5 Jul 2012 16:33:30 +0300 > From: Left Right > Cc: 11850@debbugs.gnu.org, 11813@debbugs.gnu.org > > > (gdb) p s->f->output_data.x->font > > (gdb) p *(s->f->output_data.x->font) > > (gdb) frame 3 > #3 0x000000000048eb18 in fill_glyphless_glyph_string > (s=0x7fffffffba40, face_id=13, start=8, end=68, overlaps=0) at > xdisp.c:22578 > 22578 eassert (s->font); > (gdb) p s->f->output_data.x->font > $1 = (struct font *) 0x146efd8 > (gdb) p *(s->f->output_data.x->font) > $2 = {header = {size = 4611686018429485074, next = {nbytes = 264, > buffer = 0x108, vector = 0x108}}, props = {15296386, 15541218, > 15541266, 15541170, 15362930, 102728, 102532, 102656, 68, > 400, 0, 400, 18785894, 15120722, 15558113, 15558113, 15120722, > 15296386}, max_width = 40, pixel_size = 17, height = 18, space_width = > 10, average_width = 10, min_width = 10, > ascent = 14, descent = 4, underline_thickness = 1, > underline_position = 2, vertical_centering = 0, encoding_type = 0 > '\000', baseline_offset = 0, relative_compose = 0, > default_ascent = 0, font_encoder = 0x1000040800001008, driver = > 0xdd5f60, encoding_charset = 1, repertory_charset = 1} > (gdb) OK, then does the following patch fix the problem? --- src/xdisp.c 2012-07-05 16:28:34 +0000 +++ src/xdisp.c 2012-07-05 16:51:53 +0000 @@ -22604,7 +22604,7 @@ fill_glyphless_glyph_string (struct glyp last = s->row->glyphs[s->area] + end; voffset = glyph->voffset; s->face = FACE_FROM_ID (s->f, face_id); - s->font = s->face->font; + s->font = s->face->font ? s->face->font : FRAME_FONT (s->f); s->nchars = 1; s->width = glyph->pixel_width; glyph++;