From: Eli Zaretskii <eliz@gnu.org>
To: "Left Right" <olegsivokon@gmail.com>,
"Yotam Medini יותם מדיני" <yotam.medini@gmail.com>
Cc: 11850@debbugs.gnu.org, 11813@debbugs.gnu.org
Subject: bug#11850: bug#11813: bug#11850: crash (null font) running emacs built from git
Date: Thu, 05 Jul 2012 19:54:59 +0300 [thread overview]
Message-ID: <83sjd62lng.fsf@gnu.org> (raw)
In-Reply-To: <CAJQBtgkx=WSn0YhL9e0F_oxVaqiaKok__EsAo9tL7YSiLiP2og@mail.gmail.com>
> Date: Thu, 5 Jul 2012 16:33:30 +0300
> From: Left Right <olegsivokon@gmail.com>
> Cc: 11850@debbugs.gnu.org, 11813@debbugs.gnu.org
>
> > (gdb) p s->f->output_data.x->font
> > (gdb) p *(s->f->output_data.x->font)
>
> (gdb) frame 3
> #3 0x000000000048eb18 in fill_glyphless_glyph_string
> (s=0x7fffffffba40, face_id=13, start=8, end=68, overlaps=0) at
> xdisp.c:22578
> 22578 eassert (s->font);
> (gdb) p s->f->output_data.x->font
> $1 = (struct font *) 0x146efd8
> (gdb) p *(s->f->output_data.x->font)
> $2 = {header = {size = 4611686018429485074, next = {nbytes = 264,
> buffer = 0x108, vector = 0x108}}, props = {15296386, 15541218,
> 15541266, 15541170, 15362930, 102728, 102532, 102656, 68,
> 400, 0, 400, 18785894, 15120722, 15558113, 15558113, 15120722,
> 15296386}, max_width = 40, pixel_size = 17, height = 18, space_width =
> 10, average_width = 10, min_width = 10,
> ascent = 14, descent = 4, underline_thickness = 1,
> underline_position = 2, vertical_centering = 0, encoding_type = 0
> '\000', baseline_offset = 0, relative_compose = 0,
> default_ascent = 0, font_encoder = 0x1000040800001008, driver =
> 0xdd5f60, encoding_charset = 1, repertory_charset = 1}
> (gdb)
OK, then does the following patch fix the problem?
--- src/xdisp.c 2012-07-05 16:28:34 +0000
+++ src/xdisp.c 2012-07-05 16:51:53 +0000
@@ -22604,7 +22604,7 @@ fill_glyphless_glyph_string (struct glyp
last = s->row->glyphs[s->area] + end;
voffset = glyph->voffset;
s->face = FACE_FROM_ID (s->f, face_id);
- s->font = s->face->font;
+ s->font = s->face->font ? s->face->font : FRAME_FONT (s->f);
s->nchars = 1;
s->width = glyph->pixel_width;
glyph++;
next prev parent reply other threads:[~2012-07-05 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 11:27 bug#11850: crash (null font) running emacs built from git Yotam Medini יותם מדיני
2012-07-03 16:35 ` Eli Zaretskii
2012-07-03 16:49 ` Eli Zaretskii
2012-07-04 14:31 ` Yotam Medini יותם מדיני
2012-07-04 16:32 ` Eli Zaretskii
2012-07-04 20:49 ` bug#11850: bug#11813: " Eli Zaretskii
2012-07-05 7:34 ` Left Right
2012-07-05 13:17 ` bug#11850: " Eli Zaretskii
2012-07-05 13:33 ` Left Right
2012-07-05 16:54 ` Eli Zaretskii [this message]
2012-07-07 22:42 ` Left Right
2012-07-07 22:58 ` bug#11850: " Left Right
2012-07-08 3:00 ` Eli Zaretskii
2012-07-08 14:20 ` Chong Yidong
2012-07-08 15:56 ` bug#11850: " Eli Zaretskii
2012-07-08 16:29 ` Left Right
2012-07-08 18:40 ` bug#11850: " Jan Djärv
2012-07-09 4:21 ` Chong Yidong
2012-07-11 17:36 ` Left Right
2012-07-12 7:18 ` Chong Yidong
2012-08-16 3:25 ` Chong Yidong
2012-08-16 10:51 ` bug#11813: " Left Right
2012-08-26 4:36 ` Chong Yidong
2012-09-19 13:01 ` Left Right
[not found] ` <CAAE-6rb+efByT+um7KB-MfvmN2QbOiq_GRRmuwN7drsDu8TC_A@mail.gmail.com>
[not found] ` <837guj4ffq.fsf@gnu.org>
2012-07-08 15:58 ` Yotam Medini יותם מדיני
2012-07-08 16:43 ` Eli Zaretskii
2012-07-03 17:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sjd62lng.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=11813@debbugs.gnu.org \
--cc=11850@debbugs.gnu.org \
--cc=olegsivokon@gmail.com \
--cc=yotam.medini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).