unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 16594@debbugs.gnu.org, darren.hoo@gmail.com
Subject: bug#16594: 24.3.50; very slow redraw when resizing windows horizontally
Date: Sat, 01 Feb 2014 19:46:28 +0200	[thread overview]
Message-ID: <83sis24tfv.fsf@gnu.org> (raw)
In-Reply-To: <52EC8F46.2050603@cs.ucla.edu>

> Date: Fri, 31 Jan 2014 22:08:06 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: 16594@debbugs.gnu.org
> 
> Darren Hoo wrote:
> 
> > BTW I can only reproduce it on Mac OSX, so it maybe platform specific.
> 
> Sorry, I don't use OS X.  I did build trunk bzr 110151 and 110152 on 
> Fedora 20 x86-64, configured with "./configure CFLAGS='-g3 -O0' 
> --with-x-toolkit=lucid", but I don't observe any difference in behavior.

Could this be caused by the following hunk from r110152's changes?

  @@ -3352,17 +3352,7 @@ ns_read_socket (struct terminal *termina
     if ([NSApp modalWindow] != nil)
       return -1;

  -  if (interrupt_input_blocked)
  -    {
  -      interrupt_input_pending = 1;
  -      pending_signals = 1;
  -      return -1;
  -    }
  -
  -  interrupt_input_pending = 0;
  -  pending_signals = pending_atimers;
  -
  -  BLOCK_INPUT;
  +  block_input ();
     n_emacs_events_pending = 0;
     EVENT_INIT (ev);
     emacs_event = &ev;

This is NS-specific, so it won't cause any changes on Fedora.

The removal of the condition to return early seems to be a non-trivial
change, but I don't really understand the importance of this code.





  parent reply	other threads:[~2014-02-01 17:46 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30  8:01 bug#16594: 24.3.50; very slow redraw when resizing windows horizontally Darren Hoo
2014-01-30 13:47 ` martin rudalics
2014-01-30 15:39   ` Darren Hoo
2014-01-30 16:14     ` Eli Zaretskii
2014-01-30 15:44   ` Stefan Monnier
2014-01-30 16:27     ` Eli Zaretskii
2014-01-30 16:53       ` martin rudalics
2014-01-30 17:27         ` martin rudalics
2014-01-30 17:33           ` Eli Zaretskii
2014-01-30 17:57             ` martin rudalics
2014-01-30 17:58               ` Eli Zaretskii
2014-01-30 18:57       ` Darren Hoo
2014-01-30 20:17         ` Eli Zaretskii
2014-01-31  3:16           ` Darren Hoo
2014-01-31  8:22             ` Eli Zaretskii
2014-01-31  9:58               ` Jan D.
2014-01-31 11:31                 ` Eli Zaretskii
2014-01-31 12:13                   ` Jan D.
2014-01-31 12:54                   ` Darren Hoo
2014-01-31 13:47                     ` Jan D.
2014-01-31 13:57                       ` Darren Hoo
2014-01-30 18:46     ` martin rudalics
2014-01-30 21:57       ` Stefan Monnier
2014-01-31 10:42         ` martin rudalics
2014-01-30 16:39   ` Darren Hoo
2014-01-30 16:15 ` Eli Zaretskii
2014-01-31 20:56 ` Darren Hoo
2014-02-01  6:08   ` Paul Eggert
2014-02-01  9:12     ` Darren Hoo
2014-02-01 17:46     ` Eli Zaretskii [this message]
2014-02-02  0:52       ` Paul Eggert
2014-02-02  5:28         ` Darren Hoo
2014-02-02 15:57           ` Eli Zaretskii
2014-02-02 20:48           ` Paul Eggert
2014-02-03 19:27             ` Paul Eggert
2014-02-06 13:06               ` Darren Hoo
2014-02-06 15:23                 ` Darren Hoo
2014-02-06 18:34                   ` Paul Eggert
2014-02-06 22:14                     ` Stefan Monnier
2014-02-08 22:43                       ` Darren Hoo
2014-02-09  4:17                         ` Paul Eggert
2014-02-09  6:42                           ` Darren Hoo
2014-02-09  7:09                             ` Adrian Robert
2014-02-09  7:16                               ` Adrian Robert
2014-02-09 19:43                           ` Stefan Monnier
2014-02-11  6:03                             ` Jan Djärv
2014-03-09 13:27                               ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sis24tfv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=16594@debbugs.gnu.org \
    --cc=darren.hoo@gmail.com \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).