From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18347: 24.3.93; Incomplete splash screen display on Cygwin-w32 build Date: Fri, 29 Aug 2014 09:25:01 +0300 Message-ID: <83sikfizia.fsf@gnu.org> References: <53FFA44A.3040602@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1409293735 9400 80.91.229.3 (29 Aug 2014 06:28:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Aug 2014 06:28:55 +0000 (UTC) Cc: 18347@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 29 08:28:47 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNFfz-0004P7-Ju for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Aug 2014 08:28:47 +0200 Original-Received: from localhost ([::1]:40352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNFfy-00045k-UW for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Aug 2014 02:28:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNFfo-00045a-K1 for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 02:28:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNFcO-0003uq-2d for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 02:25:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNFcN-0003so-Vm for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 02:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNFcM-0005zQ-E1 for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Aug 2014 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18347 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18347-submit@debbugs.gnu.org id=B18347.140929349723010 (code B ref 18347); Fri, 29 Aug 2014 06:25:02 +0000 Original-Received: (at 18347) by debbugs.gnu.org; 29 Aug 2014 06:24:57 +0000 Original-Received: from localhost ([127.0.0.1]:53082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNFcG-0005z4-Lo for submit@debbugs.gnu.org; Fri, 29 Aug 2014 02:24:57 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:52658) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNFcC-0005yi-UH for 18347@debbugs.gnu.org; Fri, 29 Aug 2014 02:24:54 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NB200E001DDHS00@a-mtaout22.012.net.il> for 18347@debbugs.gnu.org; Fri, 29 Aug 2014 09:24:45 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NB200EPM1T8FZ50@a-mtaout22.012.net.il>; Fri, 29 Aug 2014 09:24:45 +0300 (IDT) In-reply-to: <53FFA44A.3040602@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92797 Archived-At: > Date: Thu, 28 Aug 2014 17:51:06 -0400 > From: Ken Brown > > --- lisp/startup.el 2014-07-08 09:17:09 +0000 > +++ lisp/startup.el 2014-08-28 20:07:20 +0000 > @@ -1812,7 +1812,7 @@ > (let (chosen-frame) > ;; MS-Windows needs this to have a chance to make the initial > ;; frame visible. > - (if (eq system-type 'windows-nt) > + (if (eq window-system 'w32) > (sit-for 0 t)) > (dolist (frame (append (frame-list) (list (selected-frame)))) > (if (and (frame-visible-p frame) It is fundamentally wrong to use window-system the variable in such circumstances (or almost any other). Please use the function instead. > Is this still OK for the native Windows build? If so, is it OK to > install it in the release branch? Yes and yes. Although I'd urge you to try to figure out why this is needed in the cygwin-w32 build (the native-build problem which led to this code manifested itself in a rather different way, see bug#16014).