From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 19909@debbugs.gnu.org, rpluim@gmail.com
Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Sat, 28 Feb 2015 09:59:45 +0200 [thread overview]
Message-ID: <83sidq4gb2.fsf@gnu.org> (raw)
In-Reply-To: <54F0EEF2.1030908@cornell.edu>
> Date: Fri, 27 Feb 2015 17:25:54 -0500
> From: Ken Brown <kbrown@cornell.edu>
> CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com
>
> It looks like it might not take much effort. What I did for now, just
> for testing purposes, is to copy into w32notify.c whatever was necessary
> to make the Cygwin-w32 build compile with w32 file notification. I
> tested it briefly and it seems to work. Obviously it needs much more
> testing to make sure this doesn't break anything else, and then we can
> worry about how to do this right.
Thanks. A few comments:
. Cygwin doesn't need to call MultiByteToWideChar and
WideCharToMultiByte via function pointers, it can call them
directly.
. I think there shouldn't be a need to call filename_to_utf16 and
its ilk, but instead use the to_unicode etc., like the rest of
Cygwin-w32 code does. E.g., just use GUI_ENCODE_FILE defined on
w32term.h.
next prev parent reply other threads:[~2015-02-28 7:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 9:47 bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Robert Pluim
2015-02-20 10:06 ` Eli Zaretskii
2015-02-20 10:19 ` Robert Pluim
2015-02-20 10:46 ` Eli Zaretskii
2015-02-20 14:16 ` Robert Pluim
2015-02-20 15:10 ` Eli Zaretskii
2015-02-20 15:46 ` Robert Pluim
2015-02-20 16:17 ` Eli Zaretskii
2015-02-20 16:44 ` Robert Pluim
2015-02-20 17:16 ` Eli Zaretskii
2015-02-20 16:15 ` Ken Brown
2015-02-20 17:06 ` Robert Pluim
2015-02-20 17:18 ` Eli Zaretskii
2015-02-27 22:25 ` Ken Brown
2015-02-28 7:59 ` Eli Zaretskii [this message]
2015-02-28 16:32 ` Ken Brown
2015-02-28 16:41 ` Eli Zaretskii
2015-02-28 16:53 ` Robert Pluim
2015-02-28 16:56 ` Robert Pluim
2015-02-28 17:57 ` Eli Zaretskii
2015-02-28 18:44 ` Ken Brown
2015-02-28 19:14 ` Eli Zaretskii
2015-02-28 20:14 ` Ken Brown
2015-03-02 9:35 ` Robert Pluim
2015-03-02 14:05 ` Ken Brown
2015-03-02 14:06 ` bug#19909: closed (Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin) GNU bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sidq4gb2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=19909@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).