bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Tom Burbage]

Using current binary build of Emacs 24.4 for Windows.
emacs-24.4-bin-i686-pc-mingw32
The use context is:
1 - Open a python source file
2 - M-x pdb  ;; run gud/pdb for the current .py
3 - step until a variable becomes defined/initialized
4 - hover the mouse over the variable name in the source
The errors:
Error running timer `tooltip-timeout': (wrong-type-argument markerp nil)
Command: next [4 times]
Error running timer `tooltip-timeout': (void-variable v) [2 times]

NOTES
- I have the tooltip.el tooltip-mode OFF/nil
- I have gud-tooltip-mode ON (obviously)
- If I start Emacs w/ --no-init, I can still reproduce the problem
- If I replace progmodes/gud.el , gud.elc with those from 24.3, the
errors do not occur

Other problems ensue on Windows when tooltip messages actually display
as tooltip windows, and I suspect maybe it is an HWND stealing problem,
but not sure and that's a different issue. I'm OK with the info being
printed to the "echo area"







In GNU Emacs 24.4.1 (i686-pc-mingw32)
  of 2014-10-24 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.3.9600
Configured using:
  `configure --prefix=/c/usr'

Important settings:
   value of $LANG: ENU
   locale-coding-system: cp1252

Major mode: Messages

Minor modes in effect:
   gud-tooltip-mode: t
   pyvenv-mode: t
   minibuffer-electric-default-mode: t
   delete-selection-mode: t
   show-paren-mode: t
   global-auto-revert-mode: t
   yas-global-mode: 0
   electric-indent-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   buffer-read-only: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
<help-echo> C-x C-f d : / s r c / e x m <backspace>
a m <return> p y <return> b i t w <return> M-x p d
b <return> <return> <mouse-movement> C-c C-n C-c C-n
C-c C-n C-c C-n <mouse-movement> <mouse-movement> <help-echo>
<mouse-movement> <mouse-movement> <C-down-mouse-1>
<down-mouse-1> <mouse-movement> <mouse-movement> <drag-mouse-1>
M-w <down-mouse-1> <mouse-movement> <mouse-movement>
<drag-mouse-1> M-w <help-echo> <down-mouse-1> <mouse-1>
M-x r e p o r t - e m a c s - b u g <return>

Recent messages:
[yas] Loading for `fundamental-mode', just-in-time: (lambda nil 
(yas--load-directory-1 (quote 
c:/Users/tiburbage/.emacs.d/elpa/yasnippet-20150212.240/snippets/fundamental-mode) 
(quote fundamental-mode)))!
[yas] Loading compiled snippets from 
c:/Users/tiburbage/.emacs.d/elpa/yasnippet-20150212.240/snippets/fundamental-mode
Loading 
c:/Users/tiburbage/.emacs.d/elpa/yasnippet-20150212.240/snippets/fundamental-mode/.yas-setup...done
[yas] Prepared just-in-time loading for 
c:/Users/tiburbage/.emacs.d/elpa/yasnippet-20150212.240/snippets
[yas] Prepared just-in-time loading for ~/.emacs.d/snippets
[yas] Reloaded everything (snippets will load just-in-time)....
ad-handle-definition: `pdb' got redefined
Error running timer `tooltip-timeout': (wrong-type-argument markerp nil)
Command: next [4 times]
Error running timer `tooltip-timeout': (void-variable v) [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr warnings emacsbug message rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils gud company-files company-oddmuse company-keywords
company-etags company-gtags company-dabbrev-code company-dabbrev
company-cmake company-xcode company-clang company-eclim company-template
company-css company-nxml company-bbdb highlight-indentation flymake
company edmacro kmacro elpy pyvenv elpy-refactor grep compile files-x
etags cus-edit cus-start cus-load wid-edit python json eldoc
ecb-autoloads org-mouse org-info cl-macs cc-styles cc-align cc-engine
cc-vars cc-defs org org-macro org-footnote org-pcomplete pcomplete
org-list org-faces org-entities noutline outline org-version
ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys
ob-comint comint ansi-color ring ob-core ob-eval org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs ido minibuf-eldef
delsel paren autorevert filenotify yasnippet cl gv help-mode easy-mmode
advice help-fns dired+ image-dired cl-loaddefs cl-lib format-spec
image-file dired-aux w32-browser dired-x dired tib_dark_base-theme eieio
byte-opt bytecomp byte-compile cconv eieio-core info easymenu
pyflakes-autoloads pymacs-autoloads python-pep8-autoloads package
epg-config time-date tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win
w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp
files text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

Memory information:
((conses 8 272601 22701)
  (symbols 32 36073 0)
  (miscs 32 116 303)
  (strings 16 76881 9492)
  (string-bytes 1 2192836)
  (vectors 8 30374)
  (vector-slots 4 702227 6942)
  (floats 8 776 381)
  (intervals 28 410 2)
  (buffers 508 15))

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Eli Zaretskii]

> Date: Fri, 27 Feb 2015 14:28:51 -0800
> From: Tom Burbage <tiburbage@gmail.com>
> 
> Using current binary build of Emacs 24.4 for Windows.
> emacs-24.4-bin-i686-pc-mingw32
> The use context is:
> 1 - Open a python source file
> 2 - M-x pdb  ;; run gud/pdb for the current .py
> 3 - step until a variable becomes defined/initialized
> 4 - hover the mouse over the variable name in the source
> The errors:
> Error running timer `tooltip-timeout': (wrong-type-argument markerp nil)
> Command: next [4 times]
> Error running timer `tooltip-timeout': (void-variable v) [2 times]

I cannot reproduce this.  Does this happen for you in "emacs -Q"?

Can you show a backtrace from these errors?

Are you sure you are using gud.el, gdb-mi.el, and tooltip.el from
Emacs 24.4, not shadowing any of them with different versions?

I tested this with "M-x gdb" debugging emacs.exe, not "M-x pdb"
debugging a Python program (don't have a setup for the latter).  Do
you see the same problem with "M-x gdb"?  If not, perhaps PDB behaves
differently when it gets the request for values sent by Emacs, please
try to look into that.

> - I have the tooltip.el tooltip-mode OFF/nil
> - I have gud-tooltip-mode ON (obviously)

A strange configuration, IMO, but I tried it is a well, and still
didn't see the problem.

> - If I start Emacs w/ --no-init, I can still reproduce the problem
> - If I replace progmodes/gud.el , gud.elc with those from 24.3, the
> errors do not occur
> 
> Other problems ensue on Windows when tooltip messages actually display
> as tooltip windows, and I suspect maybe it is an HWND stealing problem,
> but not sure and that's a different issue. I'm OK with the info being
> printed to the "echo area"

I don't see any problems with tooltips on Windows, neither in GUD nor
elsewhere.  What problems do you see?

Btw, even if I turn tooltip-mode OFF, and verify it's off by hovering
the mouse above tool-bar buttons, GUD tooltips still show as balloon
help for me.  Not sure if this is a bug or a feature, but it doesn't
seem to cause any harm here.

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Eli Zaretskii]

[Please keep the bug address on the CC list.]

> Date: Sat, 28 Feb 2015 11:46:20 -0800
> From: Tom Burbage <tiburbage@gmail.com>
> 
> Here's an important update: I just tried and successfully reproduced 
> this problem on OSX using a binary version of 24.4 (from 
> http://emacsformacosx.com/). So at least it isn't something Windows 
> specific. I don't have a Linux currently to try it on.
> My OSX version: GNU Emacs 24.4.1 (x86_64-apple-darwin13.4.0, NS 
> apple-appkit-1265.21) of 2014-10-20 on builder10-9.porkrind.org
> 
> Back to the Windows steps:
> I've attached a simple .bat file (renamed to .txt with hope that an 
> attachment checker won't remove it) that you can use. Just rename it to 
> pdb.bat, then edit:
> 1 - You may need, depending on your environment, to make the path to 
> python.exe fully qualified
> 2 - For a python file, you can just save something like below to e.g. 
> test.py:
> var1 = 1
> var2 = 2
> var3 = 3
> 
> Then:
> 1 - start Emacs using -Q
> 2 - Open test.py
> 3 - M-x pdb
> 4 - (run like this) <path-to-your-pdb.bat>/pdb.bat test.py
> GUD should come up successfully
> 5 - From the "Gud" menu, Show GUD Tooltips
> 6 - Step over one or two lines
> 7 - hover over "var1" in the source
> That's were I see in the echo area:
> 
> Error running timer `tooltip-timeout': (void-variable v)

Thanks.

This is above my pay grade.  Here's the Lisp backtrace, which I hope
will allow someone to pick up where I left off:

  Lisp Backtrace:
  "process-filter" (0x82d3e0)
  0x39e2a58 Lisp type 6
  "advice--add-function" (0x82d800)
  "if" (0x82da40)
  "if" (0x82db80)
  "let" (0x82dd20)
  "if" (0x82de60)
  "progn" (0x82df70)
  "if" (0x82e080)
  "let" (0x82e220)
  "progn" (0x82e330)
  "if" (0x82e440)
  "let" (0x82e5e0)
  "gud-tooltip-tips" (0x82e84c)
  "run-hook-with-args-until-success" (0x82e848)
  "tooltip-timeout" (0x82ec0c)
  "apply" (0x82ec08)
  "byte-code" (0x82ee8c)
  "timer-event-handler" (0x82f2cc)

(In case someone wonders how did we get to advice--add-function here:
it comes from add-function in gud-tooltip-tips.  I have no idea what
is the variable 'v' which triggers the error.)

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Stefan Monnier]

Can you try the patch below?


        Stefan


diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index 42c5b20..29a6dc6 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -1,4 +1,4 @@
-;;; gud.el --- Grand Unified Debugger mode for running GDB and other debuggers
+;;; gud.el --- Grand Unified Debugger mode for running GDB and other debuggers  -*- lexical-binding:t -*-
 
 ;; Copyright (C) 1992-1996, 1998, 2000-2015 Free Software Foundation,
 ;; Inc.

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Eli Zaretskii]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Tom Burbage <tiburbage@gmail.com>, 19966@debbugs.gnu.org
> Date: Mon, 02 Mar 2015 12:31:10 -0500
> 
> Can you try the patch below?

Seems to fix the problem here, thanks.

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Stefan Monnier]

> Can you try the patch below?

Installed, along with a change in gv-ref to try and emit warnings when
bumping into similar situations.


        Stefan

bug#19966: 24.4; Get error on hover over variable for tooltip inspection, gud/pdb

[Tom Burbage]

Stefan,

Thanks for your attention to this.
I have to admit I wasn't sure what you were asking me to do per the 
patch, but it looked like it was just the addition of:

-*- lexical-binding:t -*-


so I tried replacing the first line of the gud.el that came with my 
build, byte-compiled it, and the problems are gone!

http://emacswiki.org/emacs/DynamicBindingVsLexicalBinding
and I see you (Stefan) referenced there.

Thanks again.

Tom Burbage
Redwood City, CA

On 3/2/2015 9:31 AM, Stefan Monnier wrote:
> Can you try the patch below?
>
>
>          Stefan
>
>
> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
> index 42c5b20..29a6dc6 100644
> --- a/lisp/progmodes/gud.el
> +++ b/lisp/progmodes/gud.el
> @@ -1,4 +1,4 @@
> -;;; gud.el --- Grand Unified Debugger mode for running GDB and other debuggers
> +;;; gud.el --- Grand Unified Debugger mode for running GDB and other debuggers  -*- lexical-binding:t -*-
>   
>   ;; Copyright (C) 1992-1996, 1998, 2000-2015 Free Software Foundation,
>   ;; Inc.