From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Fri, 20 Mar 2015 18:44:35 +0200 Message-ID: <83siczvcss.fsf@gnu.org> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1426869929 25530 80.91.229.3 (20 Mar 2015 16:45:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 16:45:29 +0000 (UTC) Cc: 20154@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 17:45:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZ02s-0007e1-AU for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 17:45:14 +0100 Original-Received: from localhost ([::1]:44798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ02r-00005p-Kn for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 12:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ02k-0008Tl-Dk for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:45:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ02g-0002Ce-Df for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:45:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ02g-0002CN-BF for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZ02f-0002DI-QI for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.14268698878469 (code B ref 20154); Fri, 20 Mar 2015 16:45:01 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 20 Mar 2015 16:44:47 +0000 Original-Received: from localhost ([127.0.0.1]:59319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ02Q-0002CW-SE for submit@debbugs.gnu.org; Fri, 20 Mar 2015 12:44:47 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:64523) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ02O-0002CJ-In for 20154@debbugs.gnu.org; Fri, 20 Mar 2015 12:44:45 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NLI00M00RTDT100@a-mtaout21.012.net.il> for 20154@debbugs.gnu.org; Fri, 20 Mar 2015 18:44:38 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLI00MSFRUDRD30@a-mtaout21.012.net.il>; Fri, 20 Mar 2015 18:44:38 +0200 (IST) In-reply-to: <550C491A.6000909@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100713 Archived-At: > Date: Fri, 20 Mar 2015 18:21:46 +0200 > From: Dmitry Gutov > CC: 20154@debbugs.gnu.org > > > I suggest to rewrite json-encode-char, it does a lot of unnecessary > > stuff, starting with the call to encode-char (which was needed in > > Emacs 22 and before, but no more). The call to rassoc is also > > redundant, since you already have that covered in your regexp. > > Yes, I thought about that, but as the number of calls to > `json-encode-char' must have decreased by 10 in the new version (only > each 10th character needs to be encoded), and the runtime only decreased > by 3 (or by 2, in a different example I have), the total improvement > can't be dramatic enough even if `json-encode-char' is lightning-fast. To see how much of the time is taken by json-encode-char, replace it with something trivial, like 1+, and see what speedup you get.