From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode Date: Sun, 26 Jul 2015 17:53:42 +0300 Message-ID: <83si8bynpl.fsf@gnu.org> References: <87r3nwb4t4.fsf@gmail.com> <838ua419gg.fsf@gnu.org> <55B3D2C3.8060007@gmx.at> <83y4i4ysp2.fsf@gnu.org> <55B4C42C.8020205@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1437922461 20942 80.91.229.3 (26 Jul 2015 14:54:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Jul 2015 14:54:21 +0000 (UTC) Cc: 21132@debbugs.gnu.org, flitterio@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 26 16:54:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZJNJY-0000LN-Gk for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 16:54:08 +0200 Original-Received: from localhost ([::1]:50319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJNJY-0007dR-2G for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 10:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJNJV-0007dM-5R for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 10:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJNJR-0000GA-U1 for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 10:54:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJNJR-0000G3-RH for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 10:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZJNJR-00005c-Ln for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 10:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jul 2015 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21132-submit@debbugs.gnu.org id=B21132.1437922434331 (code B ref 21132); Sun, 26 Jul 2015 14:54:01 +0000 Original-Received: (at 21132) by debbugs.gnu.org; 26 Jul 2015 14:53:54 +0000 Original-Received: from localhost ([127.0.0.1]:59276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJNJK-00005H-6A for submit@debbugs.gnu.org; Sun, 26 Jul 2015 10:53:54 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:50333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJNJI-000058-As for 21132@debbugs.gnu.org; Sun, 26 Jul 2015 10:53:53 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NS300F00NP1II00@a-mtaout23.012.net.il> for 21132@debbugs.gnu.org; Sun, 26 Jul 2015 17:53:50 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS300FDRO1QED60@a-mtaout23.012.net.il>; Sun, 26 Jul 2015 17:53:50 +0300 (IDT) In-reply-to: <55B4C42C.8020205@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105135 Archived-At: > Date: Sun, 26 Jul 2015 13:27:40 +0200 > From: martin rudalics > CC: flitterio@gmail.com, 21132@debbugs.gnu.org > > >> And do we prefer (FRAME_W32_WINDOW (f) != 0) to (!FRAME_W32_WINDOW (f))? > > > > We prefer !FRAME_W32_P (f) > > x_set_foreground_color, x_set_background_color and x_set_mouse_color use > > if (FRAME_W32_WINDOW (f) != 0) > > Should these be changed? No, I don't think so, because these are handlers for w32 frame parameters, and I see no way they could be called from Lisp, except in that context. Am I missing something? > In x_change_tool_bar_height and w32_set_title_bar_text we use > > if (FRAME_W32_WINDOW (f)) > > Should these be changed too? No, for the same reasons. > >> > I believe similar changes are needed in xfns.c and in nsfns.m, could > >> > someone with access to the relevant OSes please check and apply? > >> > >> I'll look into these. > > I fixed these hopefully. The Gtk build always crashed when invoked with > -nw so I now have `x-frame-geometry' return nil for terminal frames. Thanks.