From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Date: Tue, 08 Dec 2015 22:10:45 +0200 Message-ID: <83si3cbt16.fsf@gnu.org> References: <83bna0di5k.fsf@gnu.org> <20151208191523.GB19310@odonien.bevuta.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449605486 32579 80.91.229.3 (8 Dec 2015 20:11:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Dec 2015 20:11:26 +0000 (UTC) Cc: jwiegley@gmail.com, 22114@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 08 21:11:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6ObR-0005Uq-Hp for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 21:11:14 +0100 Original-Received: from localhost ([::1]:33337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ObP-0000Bb-Pd for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 15:11:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ObL-0000BF-Uv for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 15:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6ObG-0004IS-Ve for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 15:11:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ObG-0004IO-S5 for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 15:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a6ObG-0007db-6X for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 15:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2015 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22114-submit@debbugs.gnu.org id=B22114.144960545029342 (code B ref 22114); Tue, 08 Dec 2015 20:11:02 +0000 Original-Received: (at 22114) by debbugs.gnu.org; 8 Dec 2015 20:10:50 +0000 Original-Received: from localhost ([127.0.0.1]:43771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a6Ob4-0007dB-Cx for submit@debbugs.gnu.org; Tue, 08 Dec 2015 15:10:50 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:45233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a6Ob2-0007d2-3f for 22114@debbugs.gnu.org; Tue, 08 Dec 2015 15:10:48 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NZ200K0029G6000@a-mtaout22.012.net.il> for 22114@debbugs.gnu.org; Tue, 08 Dec 2015 22:10:46 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NZ200KB92PY2M40@a-mtaout22.012.net.il>; Tue, 08 Dec 2015 22:10:46 +0200 (IST) In-reply-to: <20151208191523.GB19310@odonien.bevuta.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109799 Archived-At: > Date: Tue, 8 Dec 2015 20:15:23 +0100 > From: Vasilij Schneidermann > Cc: 22114@debbugs.gnu.org > > > I prefer to solve the problem rather than work around it. > > I'm not sure I'm understanding this correctly. How is your suggestion > of just removing the check for whether the profiler is running not a > workaround? Removing the check is not what I alluded to. Removing the check just lifts the artificial limitation that shouldn't have been there to begin with. The problem I didn't want to work around is the one solved by this hunk: @@ -846,12 +844,12 @@ (defun profiler-report-cpu () (let ((profile (profiler-cpu-profile))) - (when profile + (when (and profile (profiler-profile-log profile)) (profiler-report-profile-other-window profile)))) (defun profiler-report-memory () (let ((profile (profiler-memory-profile))) - (when profile + (when (and profile (profiler-profile-log profile)) (profiler-report-profile-other-window profile)))) IOW, the original test was incorrect, and caused errors if only one of the 2 profiles was collected (as it usually is, since the memory profiler is mostly useless, so the only really useful one is the cpu one). > Considering that this problem hasn't been reported before, I doubt > anyone has been using the profiler seriously Actually, I use it all the time. I just never need to produce again the same report, that's all.