From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Wed, 20 Jul 2016 17:55:11 +0300 Message-ID: <83shv4z7e8.fsf@gnu.org> References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469026593 13231 80.91.229.3 (20 Jul 2016 14:56:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 14:56:33 +0000 (UTC) Cc: nljlistbox2@gmail.com, npostavs@users.sourceforge.net, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, alex.bennee@linaro.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 20 16:56:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPsuz-0002SJ-OU for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 16:56:13 +0200 Original-Received: from localhost ([::1]:35052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsuz-000598-2H for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 10:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsur-000592-U2 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 10:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPsuo-0008Us-MJ for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 10:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsuo-0008Um-If; Wed, 20 Jul 2016 10:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPsuo-0001sa-Cb; Wed, 20 Jul 2016 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Wed, 20 Jul 2016 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.14690265427198 (code B ref 23917); Wed, 20 Jul 2016 14:56:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 20 Jul 2016 14:55:42 +0000 Original-Received: from localhost ([127.0.0.1]:58741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPsuQ-0001rx-9n for submit@debbugs.gnu.org; Wed, 20 Jul 2016 10:55:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPsuL-0001rh-Ep for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 10:55:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPsuF-0008M7-JZ for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 10:55:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsty-0008EF-Cw; Wed, 20 Jul 2016 10:55:10 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4242 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPstw-0007q5-5e; Wed, 20 Jul 2016 10:55:08 -0400 In-reply-to: (message from Stefan Monnier on Tue, 19 Jul 2016 21:50:07 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121306 Archived-At: > From: Stefan Monnier > Cc: rpluim@gmail.com, 23917@debbugs.gnu.org, alex.bennee@linaro.org, jwiegley@gmail.com, nljlistbox2@gmail.com > Date: Tue, 19 Jul 2016 21:50:07 -0400 > > > Do we care that using save-match-data in every call to replace-match > > might mean a performance hit? > > I do but: > - to be honest, it's probably lost in the noise. > - if we copy search_regs.start and search_regs.end with something like > alloca+memcpy (instead of calling Fmatch_data), the cost should be even more > lost in the noise. Especially if you consider that the current code > already loops through the match-data to adjust it. > - it's the best fix we've found so far. What about Noam's suggestion: > Is it not possible to adjust the match data *before* calling buffer > modification hooks? Seems to me the root of the problem is that buffer > modification hooks get to see this invalid intermediate state where the > match data is out of sync with the buffer. Is it OK to adjust the match data before actually making the replacement? If so, I think it's a simpler solution. > PS: I can think of one (theoretical) other/better way to fix this > problem: move the match-data adjustment so it's done within > replace_range before running the after-change-functions. Isn't that almost the same as what Noam suggested?