unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 24759@debbugs.gnu.org
Subject: bug#24759: 25.1.50; electric-quote-mode
Date: Sat, 22 Oct 2016 09:49:00 +0300	[thread overview]
Message-ID: <83shrori8z.fsf@gnu.org> (raw)
In-Reply-To: <74d0a4a5-014e-b365-9d89-ad03a7fc6430@cs.ucla.edu> (message from Paul Eggert on Fri, 21 Oct 2016 14:04:56 -0700)

> Cc: 24759@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 21 Oct 2016 14:04:56 -0700
> 
> On 10/21/2016 12:58 PM, Eli Zaretskii wrote:
> > I think this condition:
> >
> >    (defun electric--insertable-p (string)
> >      (or (not buffer-file-coding-system)
> > 	(eq (coding-system-base buffer-file-coding-system) 'undecided)
> > 	(not (unencodable-char-position nil nil buffer-file-coding-system
> > 					nil string))))
> >
> > should also accept a coding-system that is the default-value of
> > buffer-file-coding-system, because that's how buffers are created.
> > When the file is saved, Emacs will ask for a proper encoding, which is
> > not a catastrophe.
> 
> Wouldn't this lead to problems? If I use electric quoting in a unibyte 
> French locale, where I the default is an ISO 8859 encoding and 
> buffer-file-coding-system is something like iso-latin-1-unix, when I 
> later save the file Emacs will say "Select coding system (default 
> chinese-iso-8bit): ". This is hardly user-friendly, even if we improve 
> Emacs to guess UTF-8, as there may be a long interval between typing ` 
> and saving the buffer.

This is standard Emacs behavior.  Emacs never makes any tests of the
current buffer-file-coding-system when you insert characters.  You
will see the same at save-buffer time if you insert the curved quotes
with, e.g., "C-x 8 [", where we insert the character no matter what is
the current buffer-file-coding-system.  Users who use
electric-quote-mode and don't have UTF-8 as their default encoding
will get accustomed to this prompt soon enough.

So I actually question the need for any test in electric--insertable-p.
What bad things, besides the prompt at save-buffer time, will happen
if we remove the test, and insert the characters unconditionally?





  reply	other threads:[~2016-10-22  6:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 19:38 bug#24759: 25.1.50; electric-quote-mode Dani Moncayo
2016-10-21 19:58 ` Eli Zaretskii
2016-10-21 20:26   ` Dani Moncayo
2016-10-21 21:01     ` Paul Eggert
2016-10-21 21:04   ` Paul Eggert
2016-10-22  6:49     ` Eli Zaretskii [this message]
2016-10-22  7:47       ` Eli Zaretskii
2016-10-22  8:16         ` Dani Moncayo
2016-10-22  9:10           ` Eli Zaretskii
2016-10-22 10:36             ` Dani Moncayo
2016-10-22 18:47       ` Paul Eggert
2016-10-22 19:04         ` Eli Zaretskii
2016-10-22 19:34           ` Eli Zaretskii
2016-10-23  4:10             ` Paul Eggert
2016-10-23  7:13               ` Eli Zaretskii
2016-10-23  8:24                 ` Paul Eggert
2016-10-23  8:51                   ` Eli Zaretskii
2016-10-22 19:20         ` Andreas Schwab
2016-10-23  3:55           ` Paul Eggert
2016-10-23  7:00             ` Eli Zaretskii
2016-10-23  8:15               ` Paul Eggert
2016-10-23  8:55                 ` Eli Zaretskii
2016-10-23  9:15                   ` Dani Moncayo
2016-10-23  9:28                     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83shrori8z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24759@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).