From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27647: 26.0.50; Line numbers implemented natively disappear momentarily when frame out of focus Date: Thu, 09 Nov 2017 17:57:07 +0200 Message-ID: <83shdnqwbw.fsf@gnu.org> References: <83eftnitpj.fsf@gnu.org> <87inekjzy8.fsf@gmail.com> <87efp8jznq.fsf@gmail.com> <87shdo4150.fsf@users.sourceforge.net> <5A0403B7.3080309@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1510243095 25846 195.159.176.226 (9 Nov 2017 15:58:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Nov 2017 15:58:15 +0000 (UTC) Cc: 27647@debbugs.gnu.org, npostavs@users.sourceforge.net, agrambot@gmail.com, kaushal.modi@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 09 16:58:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCpDU-0006T1-72 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 16:58:08 +0100 Original-Received: from localhost ([::1]:37597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCpDb-0000JD-Ji for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 10:58:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCpDS-0000J2-Ir for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 10:58:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCpDO-00084t-Iq for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 10:58:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCpDO-00084l-Ev for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 10:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCpDO-0005z6-5W for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 10:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Nov 2017 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27647-submit@debbugs.gnu.org id=B27647.151024302622937 (code B ref 27647); Thu, 09 Nov 2017 15:58:02 +0000 Original-Received: (at 27647) by debbugs.gnu.org; 9 Nov 2017 15:57:06 +0000 Original-Received: from localhost ([127.0.0.1]:60591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCpCU-0005xt-79 for submit@debbugs.gnu.org; Thu, 09 Nov 2017 10:57:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCpCS-0005xO-Dc for 27647@debbugs.gnu.org; Thu, 09 Nov 2017 10:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCpCM-0007d0-G7 for 27647@debbugs.gnu.org; Thu, 09 Nov 2017 10:56:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCpCH-0007b6-TW; Thu, 09 Nov 2017 10:56:53 -0500 Original-Received: from [176.228.60.248] (port=2925 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eCpCH-0007Hi-Bv; Thu, 09 Nov 2017 10:56:53 -0500 In-reply-to: <5A0403B7.3080309@gmx.at> (message from martin rudalics on Thu, 09 Nov 2017 08:28:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139667 Archived-At: > Date: Thu, 09 Nov 2017 08:28:55 +0100 > From: martin rudalics > Cc: 27647@debbugs.gnu.org, Kaushal Modi > > And yes, we wouldn't have had that problem if we had left in (parts > of) the code Dmitry Antipov installed some time ago where "The goal > was to avoid tricky global variables". What changes did you allude to here? Can you point me to them? In general, using the same variable for two different purposes is exactly what I was talking about in the discussion of wait_reading_process_output discussion -- who could possibly keep all such factoids in memory, and avoid making such subtle mistakes as result? I also wonder whether other places which seem to be similarly vulnerable hide bugs. For example, what about frame-list: DEFUN ("frame-list", Fframe_list, Sframe_list, 0, 0, 0, doc: /* Return a list of all live frames. */) (void) { Lisp_Object frames; frames = Fcopy_sequence (Vframe_list); #ifdef HAVE_WINDOW_SYSTEM if (FRAMEP (tip_frame)) frames = Fdelq (tip_frame, frames); #endif return frames; } Does this mean that in a GTK build, at some "opportune moment", frame-list will omit one frame from the list it returns, because that frame happens to show a tooltip at that very moment? Or what about a similar snippet in x-display-monitor-attributes-list? Is it in trouble as well? IOW, instead a simple variable with a clear semantics, we now have a potential trap, whereby for every use of this variable we need to make non-trivial reasoning whether this issue could or couldn't hit us. I think we should get rid of this ambiguity on master. Patches to that effect are welcome.