From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: 30198-done@debbugs.gnu.org
Subject: bug#30198: 26.0.91; [PATCH] Fix emacs-module-tests to work with out of tree build directory
Date: Fri, 26 Jan 2018 12:12:34 +0200 [thread overview]
Message-ID: <83shatkjxp.fsf@gnu.org> (raw)
In-Reply-To: <a2f64144-0bf7-17c2-5c7b-140f2cc569c6@gmail.com> (message from Andy Moreton on Sun, 21 Jan 2018 18:44:16 +0000)
> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sun, 21 Jan 2018 18:44:16 +0000
>
> Currently the emacs module tests fail to build when using an out of tree
> build directory. The following patch moves the location of the module
> library mod-test.{so,dll} from test/data/emacs-module to
> <builddir>/test/data/emacs-module, as build outputs do not belong in the
> source tree. It also fixes the test module build to find the module header
> at the correct lcoation, namely <builddir>/src/emacs-module.h.
>
> Tested on Windows with the mingw64-x86_64 toolchain (msys2) for both
> both in-tree and out-of-tree build directories:
Thanks, pushed to the master branch.
(Note that your mailer caused the patch fail to apply due to changes
in whitespace.)
next prev parent reply other threads:[~2018-01-26 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 18:44 bug#30198: 26.0.91; [PATCH] Fix emacs-module-tests to work with out of tree build directory Andy Moreton
2018-01-26 10:12 ` Eli Zaretskii [this message]
2018-01-26 13:58 ` bug#30198: 26.0.91; " Andy Moreton
2018-01-26 15:42 ` Eli Zaretskii
2018-01-26 19:54 ` Glenn Morris
2018-01-26 20:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shatkjxp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30198-done@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).