From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30559: 26.0.91; grep-use-null-filename-separator customization Date: Fri, 02 Mar 2018 10:26:00 +0200 Message-ID: <83sh9ix4rr.fsf@gnu.org> References: <87k1v7qsop.fsf@mail.linkov.net> <83lgfn6md1.fsf@gnu.org> <87fu5jfm89.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1519979048 5577 195.159.176.226 (2 Mar 2018 08:24:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Mar 2018 08:24:08 +0000 (UTC) Cc: 30559@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 02 09:24:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erfz1-0000pH-CW for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Mar 2018 09:24:03 +0100 Original-Received: from localhost ([::1]:33314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erg13-0000ZP-QR for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Mar 2018 03:26:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erg0x-0000Yx-6m for bug-gnu-emacs@gnu.org; Fri, 02 Mar 2018 03:26:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erg0w-0005LV-BY for bug-gnu-emacs@gnu.org; Fri, 02 Mar 2018 03:26:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erg0w-0005LP-73 for bug-gnu-emacs@gnu.org; Fri, 02 Mar 2018 03:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1erg0w-00060Z-0p for bug-gnu-emacs@gnu.org; Fri, 02 Mar 2018 03:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Mar 2018 08:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 30559-submit@debbugs.gnu.org id=B30559.151997915923086 (code B ref 30559); Fri, 02 Mar 2018 08:26:01 +0000 Original-Received: (at 30559) by debbugs.gnu.org; 2 Mar 2018 08:25:59 +0000 Original-Received: from localhost ([127.0.0.1]:40041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erg0s-00060I-Qt for submit@debbugs.gnu.org; Fri, 02 Mar 2018 03:25:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erg0q-000605-P4 for 30559@debbugs.gnu.org; Fri, 02 Mar 2018 03:25:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erg0i-0005GJ-AX for 30559@debbugs.gnu.org; Fri, 02 Mar 2018 03:25:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erg0i-0005GF-7M; Fri, 02 Mar 2018 03:25:48 -0500 Original-Received: from [176.228.60.248] (port=1495 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1erg0h-0007iz-Lz; Fri, 02 Mar 2018 03:25:48 -0500 In-reply-to: <87fu5jfm89.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 02 Mar 2018 00:45:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143824 Archived-At: > From: Juri Linkov > Cc: 30559@debbugs.gnu.org > Date: Fri, 02 Mar 2018 00:45:27 +0200 > > Sorry, I forgot to do the same for zrgrep. I already noticed earlier > that grep-use-null-filename-separator let-binding is missing here, > but forgot to test this to affirm the necessity to fix zrgrep too. > So this fix is needed for the release branch. > > Eli, is it OK to push this patch to emacs-26 as well? > > diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el > index 755c9c7..9b6ebee 100644 > --- a/lisp/progmodes/grep.el > +++ b/lisp/progmodes/grep.el > @@ -1184,6 +1184,7 @@ zrgrep > ;; by `grep-compute-defaults'. > (grep-find-template nil) > (grep-find-command nil) > + (grep-use-null-filename-separator nil) > (grep-host-defaults-alist nil) > ;; Use for `grep-read-files' > (grep-files-aliases '(("all" . "* .*") Yes, but please add a comment there explaining why this is done. (And AFAIU, our auto-detect stuff needs fixing, if it must be overridden like that.) Thanks.