From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31656: 26.1; `fill-paragraph' malformats in emacs-lisp-mode Date: Fri, 01 Jun 2018 12:20:52 +0300 Message-ID: <83sh66g8wb.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1527844923 8828 195.159.176.226 (1 Jun 2018 09:22:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 1 Jun 2018 09:22:03 +0000 (UTC) Cc: 31656@debbugs.gnu.org To: Stefan Guath Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 01 11:21:58 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOgFv-00026U-Ly for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jun 2018 11:21:55 +0200 Original-Received: from localhost ([::1]:54353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOgI2-0004uf-Nm for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jun 2018 05:24:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOgG6-0003er-Ix for bug-gnu-emacs@gnu.org; Fri, 01 Jun 2018 05:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOgG2-0004O2-KH for bug-gnu-emacs@gnu.org; Fri, 01 Jun 2018 05:22:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48898) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fOgG2-0004Nu-Gc for bug-gnu-emacs@gnu.org; Fri, 01 Jun 2018 05:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fOgG2-0006yH-As for bug-gnu-emacs@gnu.org; Fri, 01 Jun 2018 05:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jun 2018 09:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31656 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31656-submit@debbugs.gnu.org id=B31656.152784486326735 (code B ref 31656); Fri, 01 Jun 2018 09:22:02 +0000 Original-Received: (at 31656) by debbugs.gnu.org; 1 Jun 2018 09:21:03 +0000 Original-Received: from localhost ([127.0.0.1]:56795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOgF5-0006x7-FV for submit@debbugs.gnu.org; Fri, 01 Jun 2018 05:21:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOgF3-0006wK-Fq for 31656@debbugs.gnu.org; Fri, 01 Jun 2018 05:21:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOgEu-0003tB-C7 for 31656@debbugs.gnu.org; Fri, 01 Jun 2018 05:20:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOgEu-0003t5-84; Fri, 01 Jun 2018 05:20:52 -0400 Original-Received: from [176.228.60.248] (port=4151 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fOgEt-0001U7-Kj; Fri, 01 Jun 2018 05:20:52 -0400 In-reply-to: (message from Stefan Guath on Wed, 30 May 2018 14:50:01 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146810 Archived-At: > From: Stefan Guath > Date: Wed, 30 May 2018 14:50:01 +0200 > > `emacs-lisp-docstring-fill-column' shadows `fill-column' in too many cases in emacs-lisp-mode. The > documentation of `emacs-lisp-docstring-fill-column' states: "Value of ‘fill-column’ to use when filling a > docstring". But it incorrectly seems to be used in a lot more cases than just in a docstring (the only case that > I've found where ‘fill-column’ is actually respected is within comments). A work-around is to set > `emacs-lisp-docstring-fill-column' to nil, but it would be nice to have it working properly instead. > > I might be missing something, but think the incorrect behavior is to be found in `lisp-fill-paragraph' that is > invoked by `fill-paragraph' through `fill-paragraph-function'. It seems like `lisp-fill-paragraph' unconditionally > sets `fill-column' to `emacs-lisp-docstring-fill-column' without checking whether point is within a doc string > first. The only requirements for enable shadowing currently seems to be "(and (integerp > emacs-lisp-docstring-fill-column) (derived-mode-p 'emacs-lisp-mode))", which doesn't seems sufficient. AFAICT, this behavior was in Emacs since about forever (since 1995, t be precise). So maybe we just need to adjust the doc string to reflect the reality? Or are there real-life use cases where this behavior is grossly inappropriate?