From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: npostavs@gmail.com, 31996@debbugs.gnu.org
Subject: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree
Date: Fri, 29 Jun 2018 09:13:46 +0300 [thread overview]
Message-ID: <83sh56nmqt.fsf@gnu.org> (raw)
In-Reply-To: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> (message from Paul Eggert on Thu, 28 Jun 2018 15:57:46 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 28 Jun 2018 15:57:46 -0700
> Cc: 31996@debbugs.gnu.org
>
> Noam Postavsky wrote:
> > Maybe that kind of trick deserves a code comment?
>
> I thought about doing that, but it seemed like the maintenance cost of having
> the comment there indefinitely wasn't worth the minor performance benefit (a
> benefit that applies only to typical platforms and when optimization is enabled,
> facts that'd also probably need to be in the comment). For what it's worth, this
> stuff is now documented in the bug report....
But maybe a comment explaining why the order might matter in general
could be of more value, and require less maintenance.
next prev parent reply other threads:[~2018-06-29 6:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 19:10 bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Noam Postavsky
2018-06-28 19:18 ` Eli Zaretskii
2018-06-28 19:20 ` Noam Postavsky
2018-06-28 20:29 ` Andy Moreton
2018-06-28 20:55 ` Paul Eggert
2018-06-28 21:05 ` Noam Postavsky
2018-06-28 22:57 ` Paul Eggert
2018-06-29 6:13 ` Eli Zaretskii [this message]
2018-06-29 7:30 ` Paul Eggert
2018-06-29 8:52 ` Eli Zaretskii
2018-06-29 12:30 ` Noam Postavsky
2018-06-29 18:18 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sh56nmqt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31996@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).