From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32731: 26.1.50; Ibuffer filter by mode: Handle >1 mode names Date: Wed, 19 Sep 2018 12:42:28 +0300 Message-ID: <83sh25escb.fsf@gnu.org> References: <87bm919s5y.fsf@calancha-pc.dy.bbexcite.jp> <874let9lps.fsf@calancha-pc.dy.bbexcite.jp> <87ftydezmi.fsf@gmail.com> <87worn86l5.fsf@calancha-pc.dy.bbexcite.jp> <878t43rkxd.fsf@gmail.com> <87sh2881dv.fsf@calancha-pc.dy.bbexcite.jp> <871s9qqtq1.fsf@gmail.com> <877ejh96xj.fsf@calancha-pc.dy.bbexcite.jp> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537350071 8957 195.159.176.226 (19 Sep 2018 09:41:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2018 09:41:11 +0000 (UTC) Cc: npostavs@gmail.com, 32731@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 11:41:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Yyk-000271-HS for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 11:41:02 +0200 Original-Received: from localhost ([::1]:44476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Z0q-0001XT-Th for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 05:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Z0i-0001Wk-Ad for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 05:43:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Z0g-0005mk-Mo for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 05:43:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2Z0g-0005mX-EV for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 05:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2Z0g-00012J-BT for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Sep 2018 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32731-submit@debbugs.gnu.org id=B32731.15373501793974 (code B ref 32731); Wed, 19 Sep 2018 09:43:02 +0000 Original-Received: (at 32731) by debbugs.gnu.org; 19 Sep 2018 09:42:59 +0000 Original-Received: from localhost ([127.0.0.1]:45145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Z0d-000122-0U for submit@debbugs.gnu.org; Wed, 19 Sep 2018 05:42:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Z0b-00011m-5h for 32731@debbugs.gnu.org; Wed, 19 Sep 2018 05:42:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Z0S-0005cq-GL for 32731@debbugs.gnu.org; Wed, 19 Sep 2018 05:42:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Z09-0005SJ-DD; Wed, 19 Sep 2018 05:42:48 -0400 Original-Received: from [176.228.60.248] (port=4236 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2Z07-0006og-Rh; Wed, 19 Sep 2018 05:42:28 -0400 In-reply-to: <877ejh96xj.fsf@calancha-pc.dy.bbexcite.jp> (message from Tino Calancha on Wed, 19 Sep 2018 18:23:52 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150447 Archived-At: > From: Tino Calancha > Date: Wed, 19 Sep 2018 18:23:52 +0900 > Cc: 32731@debbugs.gnu.org > > Following patch adds a key :composable, which also serves as > documentation. Thanks, a few nits to the documentation parts: > --- > +*** All mode filters accept a symbol or a list of symbols, i.e., you > +can filter several major modes with easy. Please try to keep the first line in a NEWS item a single complete sentence, as much as possible: that allows for more convenient browsing in Outline mode. In this case, I would break this into two sentences: a short announcement and followup details: *** All mode filters can now accept a list of symbols. This means you can now easily filter several major modes, as well as a single mode. > ;;;###autoload (autoload 'ibuffer-filter-by-mode "ibuf-ext") > (define-ibuffer-filter mode > - "Limit current view to buffers with major mode QUALIFIER." > + "Limit current view to buffers with major mode in QUALIFIER. > +QUALIFIER is the mode name as a symbol or a list of symbols. In the first sentence, I'd suggest to rephrase: Limit current view to buffers with major mode(s) specified by QUALIFIER. because "in QUALIFIER" only covers the case of a list. Similarly in other doc strings you modified the same way. > +Called interactively, accept a comma separated list of mode names. > +When called interactively, this function allows selection of modes > currently used by buffers." These two sentences seem to be in contradiction, so they probably need to be merged or rephrased. > (cl-defmacro define-ibuffer-filter (name documentation > (&key > reader > - description) > + description > + composable) > &rest body) > "Define a filter named NAME. > DOCUMENTATION is the documentation of the function. > READER is a form which should read a qualifier from the user. > DESCRIPTION is a short string describing the filter. > +COMPOSABLE is a boolean; if non-nil, the filter accepts both, ^ That comma should be deleted, it gets in the way of understanding what you mean. And I would actually rephrase if non-nil, the filter accepts either a single condition or a list of them because "both" might be interpreted as meaning "and", not "or". I also wonder whether "COMPOSABLE" is a good name for this argument; how about ACCEPT-LIST instead? Thanks for working on this.