From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 33335-done@debbugs.gnu.org
Subject: bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash'
Date: Sat, 10 Nov 2018 22:18:00 +0200 [thread overview]
Message-ID: <83sh08adqf.fsf@gnu.org> (raw)
In-Reply-To: <2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default> (message from Drew Adams on Sat, 10 Nov 2018 11:12:40 -0800 (PST))
> Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
>
> Both of these doc strings seem to say that if function
> `system-move-file-to-trash' is defined then it is used, regardless of
> the value of option `trash-directory'.
>
> A cursory look at the code defining `move-file-to-trash' suggests
> otherwise. And that would seem to make sense, giving users a way
> to customize the directory in all cases.
>
> Are the doc strings wrong, or am I misreading the code?
It's a (subtle) bug, which I just fixed.
Thanks.
prev parent reply other threads:[~2018-11-10 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 19:12 bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Drew Adams
2018-11-10 20:18 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sh08adqf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33335-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).