unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 36861@debbugs.gnu.org, juri@linkov.net
Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode
Date: Wed, 07 Aug 2019 17:42:14 +0300	[thread overview]
Message-ID: <83sgqdavg9.fsf@gnu.org> (raw)
In-Reply-To: <2F586079-3687-4DF0-984D-467F442E68D1@aol.com> (message from Ergus on Tue, 06 Aug 2019 21:25:00 +0200)

> Date: Tue, 06 Aug 2019 21:25:00 +0200
> CC: juri@linkov.net,36861@debbugs.gnu.org
> From: Ergus <spacibba@aol.com>
> 
> We can do that... I was just trying to avoid using ?| by default in any case. 

Why should we avoid that?  It might be not the best alternative, but
at least it lets users who just set the mode variable have an
indicator.  If they want a prettier display, they will have to call
the mode function instead, as they do now.  So I think this is a net
win.  Or am I missing something?

> There is also the case when a user sets ?| by default and then call the function. If the check we add is just
> comparing to the default value then ?| will be always overwritten so an extra internal variable will be needed to
> cache where the ?| comes from.

Not sure we need another variable.  After all, if the conditions
stayed the same, the result will be the same as well, and you will
overwrite the value with an identical one.  Right?





  reply	other threads:[~2019-08-07 14:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 20:44 bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Juri Linkov
2019-07-30 21:21 ` Juri Linkov
2019-07-31  2:30 ` Eli Zaretskii
2019-07-31 20:49   ` Juri Linkov
2019-08-02  9:10     ` Eli Zaretskii
2019-08-03 22:31       ` Juri Linkov
2019-08-04  0:51         ` Ergus
2019-08-04 19:39           ` Juri Linkov
2019-08-04 20:30             ` Ergus
2019-08-06 14:59               ` Eli Zaretskii
2019-08-06 17:51                 ` Ergus
2019-08-06 18:26                   ` Eli Zaretskii
2019-08-06 19:25                     ` Ergus
2019-08-07 14:42                       ` Eli Zaretskii [this message]
2020-08-09 19:18                         ` Lars Ingebrigtsen
2019-08-05 21:43       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgqdavg9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36861@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).