unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 38026@debbugs.gnu.org
Subject: bug#38026: [PATCH] Explain negative NABS in `goto-history-element'.
Date: Sat, 02 Nov 2019 19:54:14 +0200	[thread overview]
Message-ID: <83sgn6i2pl.fsf@gnu.org> (raw)
In-Reply-To: <86065fb6-a830-a575-f5c4-7cae336a768d@topbug.net> (message from Hong Xu on Sat, 2 Nov 2019 10:07:03 -0700)

> Cc: 38026@debbugs.gnu.org
> From: Hong Xu <hong@topbug.net>
> Date: Sat, 2 Nov 2019 10:07:03 -0700
> 
> On 11/2/19 1:03 AM, Eli Zaretskii wrote:
> > Thanks, but I don't see how this clarifies the issue.  Can you tell
> > more about your motivation?
> > 
> 
> The motivation is to clarify what a negative NABS means. From the current document, it is unclear that NABS can be negative.

In that case, the patch is insufficient.  First, we don't document
minibuffer-default in the manual, so referencing it will leave the
reader wondering what it is, and how it is set and used.  Second, the
doc string of goto-history-element should also explain what is the
meaning of negative values.  And third, several functions bind
minibuffer-default to certain values, and I'm not sure this variable
can usefully be documented in a manual.

So I think the text needs not reference minibuffer-default, but
instead talk about "future history", like the Emacs manual does.

Thanks.





  reply	other threads:[~2019-11-02 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  1:08 bug#38026: [PATCH] Explain negative NABS in `goto-history-element' Hong Xu
2019-11-02  8:03 ` Eli Zaretskii
2019-11-02 17:07   ` Hong Xu
2019-11-02 17:54     ` Eli Zaretskii [this message]
2019-11-03  5:11       ` Hong Xu
2019-11-09  9:46         ` Eli Zaretskii
2019-11-09 18:48           ` Hong Xu
2019-11-09 20:00             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgn6i2pl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38026@debbugs.gnu.org \
    --cc=hong@topbug.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).